Re: pkg/55364: *.subst.sav files not removed ending up in PLIST mismatch (was: pkgsrc/lang/python27, 37, 38 are broken on NetBSD)

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/55364; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/55364: *.subst.sav files not removed ending up in PLIST mismatch (was: pkgsrc/lang/python27, 37, 38 are broken on NetBSD)
Date: Thu, 11 Jun 2020 11:05:36 +0200

 Hello Thomas and John,
 
 Thomas Klausner writes:
 >  [...]
 >  Perhaps on NetBSD/alpha.
 >  
 >  On NetBSD i386 and x86_64 they are not, see
 >  https://mail-index.netbsd.org/pkgsrc-bulk/2020/06/10/msg019074.html (pkgsrc-2020Q1 x86_64)
 >  https://mail-index.netbsd.org/pkgsrc-bulk/2020/06/09/msg019073.html (pkgsrc-current x86_64)
 >  https://mail-index.netbsd.org/pkgsrc-bulk/2020/06/10/msg019077.html (pkgsrc-2020Q1 i386)
 >  
 >  (Please note that python37 basically didn't change compared to pkgsrc-2020Q1.)
 >  [...]
 
 I don't think that's a "classical" PLIST issue (missing files or extra
 files installed) neither a NetBSD/alpha specific problem but looks like
 a subst fallout:
 
  | pkgsrc/lang/python37:
  | 
  | => Checking file-check results for python37-3.7.7
  | ERROR: ************************************************************
  | ERROR: The following files are in /usr/pkgsrc/lang/python37/work/.destdir/usr/local but not in the PLIST:
  | ERROR:         /usr/pkgsrc/lang/python37/work/.destdir/usr/local/lib/python3.7/ctypes/macholib/dyld.py.subst.sav
  | ERROR:         /usr/pkgsrc/lang/python37/work/.destdir/usr/local/lib/python3.7/distutils/unixccompiler.py.subst.sav
  | *** Error code 1
 
 ...the *.subst.sav are temporary files that should be removed but I
 think that in the code path of mk/subst.mk,-r1.95 lines 208-209 they
 could ends up to be accidentally not removed.
 
 (But I only stared at that last night and I'm pretty unfamiliar with
 the code.)