pkg/55410: cppcheck dumps core

[Thomas Klausner <wiz%NetBSD.org@localhost>]

>Number:         55410
>Category:       pkg
>Synopsis:       cppcheck dumps core
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 23 20:40:00 +0000 2020
>Originator:     Thomas Klausner
>Release:        NetBSD 9.99.67
>Organization:
Curiosity is the very basis of education and if you tell me that
curiosity killed the cat, I say only that the cat died nobly.
- Arnold Edinborough
>Environment:
	
	
Architecture: x86_64
Machine: amd64
>Description:
Except when showing the help text, cppcheck dumps core.
Tested on 9.99.67/amd64 by myself and 8.0/amd64 by ginsbach@
>How-To-Repeat:
mkdir a
cd a
touch a.c
cppcheck .

Backtrace:
Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000000000069e3be in tinyxml2::XMLNode::DeleteNode (node=0x7f7fff96a830) at /scratch/devel/cppcheck/work/cppcheck-2.1/externals/tinyxml/tinyxml2.cpp:1094
1094    /scratch/devel/cppcheck/work/cppcheck-2.1/externals/tinyxml/tinyxml2.cpp: No such file or directory.
(gdb) btr
Undefined command: "btr".  Try "help".
(gdb) bt
#0  0x000000000069e3be in tinyxml2::XMLNode::DeleteNode (node=0x7f7fff96a830) at /scratch/devel/cppcheck/work/cppcheck-2.1/externals/tinyxml/tinyxml2.cpp:1094
#1  0x000000000069e4e5 in tinyxml2::XMLNode::DeleteChild (this=<optimized out>, node=<optimized out>)
    at /scratch/devel/cppcheck/work/cppcheck-2.1/externals/tinyxml/tinyxml2.cpp:837
#2  0x00000000006a2294 in tinyxml2::XMLNode::DeleteChildren (this=0x7f7fff96a608) at /scratch/devel/cppcheck/work/cppcheck-2.1/externals/tinyxml/tinyxml2.cpp:798
#3  tinyxml2::XMLDocument::Clear (this=this@entry=0x7f7fff96a608) at /scratch/devel/cppcheck/work/cppcheck-2.1/externals/tinyxml/tinyxml2.cpp:2035
#4  0x00000000006a2f87 in tinyxml2::XMLDocument::LoadFile (this=this@entry=0x7f7fff96a608, filename=0x7f7fff96a730 "/std.cfg")
    at /scratch/devel/cppcheck/work/cppcheck-2.1/externals/tinyxml/tinyxml2.cpp:2160
#5  0x00000000005889e7 in Library::load (this=this@entry=0x7f7fff96b208, exename=<optimized out>, path=path@entry=0x7db1d7 "std.cfg")
    at /usr/include/g++/bits/basic_string.h:2290
#6  0x0000000000410b8d in CppCheckExecutor::tryLoadLibrary (destination=..., basepath=<optimized out>, filename=filename@entry=0x7db1d7 "std.cfg")
    at /scratch/devel/cppcheck/work/cppcheck-2.1/cli/cppcheckexecutor.cpp:1125
#7  0x0000000000414f7a in CppCheckExecutor::check_internal (this=this@entry=0x7f7fff96c1b0, cppcheck=..., argv=argv@entry=0x7f7fff96c658)
    at /scratch/devel/cppcheck/work/cppcheck-2.1/cli/cppcheckexecutor.cpp:850
#8  0x0000000000417d45 in CppCheckExecutor::check (this=this@entry=0x7f7fff96c1b0, argc=argc@entry=2, argv=argv@entry=0x7f7fff96c658)
    at /scratch/devel/cppcheck/work/cppcheck-2.1/cli/cppcheckexecutor.cpp:232
#9  0x00000000006efd5c in main (argc=2, argv=<optimized out>) at /scratch/devel/cppcheck/work/cppcheck-2.1/cli/main.cpp:95
(gdb)

Please note that this uses tinyxml from its subdirectory
instead of the installed copy.
>Fix:
I tried updating to the latest version (2.1) but saw the same problem.
According to ginsbach that version works on macOS.
The updated pkgsrc version is in wip/cppcheck.

>Unformatted: