Re: pkg/55455: No gir file in gtkspell3

[Leonardo Taccari <leot%NetBSD.org@localhost>]

The following reply was made to PR pkg/55455; it has been noted by GNATS.

From: Leonardo Taccari <leot%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/55455: No gir file in gtkspell3
Date: Fri, 03 Jul 2020 22:39:12 +0200

 Hello!
 A couple of suggested changes directly inline.
 
 mcbig%zeropage.cz@localhost writes:
 > [...]
 > >Fix:
 > ? work
 > cvs diff: Diffing .
 > Index: Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/textproc/gtkspell3/Makefile,v
 > retrieving revision 1.10
 > diff -u -r1.10 Makefile
 > --- Makefile    20 Mar 2020 11:58:26 -0000      1.10
 > +++ Makefile    3 Jul 2020 19:00:10 -0000
 > @@ -1,7 +1,7 @@
 >  # $NetBSD: Makefile,v 1.10 2020/03/20 11:58:26 nia Exp $
 >  
 >  DISTNAME=      gtkspell3-3.0.10
 > -PKGREVISION=   4
 > +PKGREVISION=   5
 >  CATEGORIES=    textproc devel
 >  MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=gtkspell/}
 >  EXTRACT_SUFX=  .tar.xz
 > @@ -17,6 +17,21 @@
 >  PKGCONFIG_OVERRIDE=    gtkspell-3.0.pc.in
 >  CONFIGURE_ARGS+=       --disable-gtk-doc
 >  
 > +PKG_OPTIONS_VAR=       PKG_OPTIONS.gtkspell3
 > +PKG_SUPPORTED_OPTIONS= introspection
 > +PKG_SUGGESTED_OPTIONS= introspection
 > +PLIST_VARS+=           introspection
 > +
 > +.include "../../mk/bsd.options.mk"
 > +
 > +.if !empty(PKG_OPTIONS:Mintrospection)
 > +PLIST.introspection=   yes
 > +BUILDLINK_API_DEPENDS.gobject-introspection+=  gobject-introspection>=1.42.0
 > +.include "../../devel/gobject-introspection/buildlink3.mk"
 > +.else
 > +CONFIGURE_ARGS+=       --enable-introspection=no
 > +.endif
 > +
 > [...]
 
 Only cosmetic: it would be better to move all the option logic in a
 separate options.mk file in order to separate the logic regarding
 options in a separate file.
 
 Can you please also use `--disable-introspection' instead of
 `--enable-introspection=no' (it is easier to read) and explicitly also
 pass `--enable-introspection' (so if for any reason the option could not
 be enabled it should fail to build instead of silently disable
 introspection support)?
 
 > Index: PLIST
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/textproc/gtkspell3/PLIST,v
 > retrieving revision 1.2
 > diff -u -r1.2 PLIST
 > --- PLIST       13 Nov 2018 13:33:29 -0000      1.2
 > +++ PLIST       3 Jul 2020 19:00:10 -0000
 > @@ -1,7 +1,9 @@
 > -@comment $NetBSD: PLIST,v 1.2 2018/11/13 13:33:29 bsiegert Exp $
 > +@comment $NetBSD$
 >  include/gtkspell-3.0/gtkspell/gtkspell.h
 > +lib/girepository-1.0/GtkSpell-3.0.typelib
 >  lib/libgtkspell3-3.la
 >  lib/pkgconfig/gtkspell3-3.0.pc
 > +share/gir-1.0/GtkSpell-3.0.gir
 > [...]
 
 I think that both new entries are missing a ${PLIST.introspection},
 please add it.