pkg/55516: pkgtools/pkglint objecting to comments

[dholland%NetBSD.org@localhost]

>Number:         55516
>Category:       pkg
>Synopsis:       pkgtools/pkglint objecting to comments
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 26 05:15:00 +0000 2020
>Originator:     David A. Holland
>Release:        irrelevant, pkglint 20.1.19 from 20200622
>Organization:
>Environment:
System: irrelevant
Architecture: x86_64
Machine: amd64
>Description:

I have a patch with (among other things) this text:
    // Special case, for Linux: the resource files are not in the same place as
    // the executable, but are under the same prefix (/usr or /usr/local).
 +  // ...or /usr/pkg or /usr/contrib or /opt or...

which prompts pkglint to object with

ERROR: patches/patch-source_Files.cpp:41: Patches must not hard-code the pkgsrc PREFIX.

which is, ultimately, pretty silly.

Maybe pkglint can skip comments on patches based on the filename
suffix, since we now name patches after the file they patch?

Just doing the equivalent of

   case $PATCH in
      *.[ch]|*.[CH]|*.[ch]pp|*.[ch]xx) sed 's,//.*,,;s,/\*[^*]\*/,,'
      *.sh|*.mk) sed 's,#.*,,'
      *) cat
   esac

would cover a large fraction of the cases at little cost.

>How-To-Repeat:

as above.

>Fix: