pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/55544: sysutils/ansible: use /proc/mounts
The following reply was made to PR pkg/55544; it has been noted by GNATS.
From: =?UTF-8?Q?J=C3=B6rn_Clausen?= <joernc%googlemail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/55544: sysutils/ansible: use /proc/mounts
Date: Thu, 6 Aug 2020 08:32:24 +0200
--00000000000066113105ac2fa704
Content-Type: text/plain; charset="UTF-8"
Feel free to provide a better solution.
I have a) no skills in programming Python and b) no knowledge of the inner
workings of ansible (or the desire to learn them). The current code is 3
years old, and already uses /proc/cpuinfo and /proc/meminfo, so this is
just a normalization of what is already there.
On Wed, Aug 5, 2020 at 10:45 PM Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
> The following reply was made to PR pkg/55544; it has been noted by GNATS.
>
> From: Joerg Sonnenberger <joerg%bec.de@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Cc:
> Subject: Re: pkg/55544: sysutils/ansible: use /proc/mounts
> Date: Wed, 5 Aug 2020 22:40:01 +0200
>
> On Wed, Aug 05, 2020 at 07:35:00PM +0000, joernc%gmail.com@localhost wrote:
> > >Number: 55544
> > >Category: pkg
> > >Synopsis: sysutils/ansible: use /proc/mounts
> > >Confidential: no
> > >Severity: serious
> > >Priority: medium
> > >Responsible: pkg-manager
> > >State: open
> > >Class: sw-bug
> > >Submitter-Id: net
> > >Arrival-Date: Wed Aug 05 19:35:00 +0000 2020
> > >Originator: Joern Clausen
> > >Release:
> > >Organization:
> > >Environment:
> > >Description:
> > The fact gathering code for NetBSD already uses /proc in some cases,
> but reads /etc/fstab to find mounted filesystems. This misses usually
> (well, at least in my case) ZFS mounts, which are no longer documented
> there.
> >
> > >How-To-Repeat:
> > $ ansible foo -m setup
> >
> > will not report mounts on foo except those documented in /etc/fstab
> > >Fix:
> > https://github.com/ansible/ansible/pull/71113 is a pull request to
> read /proc/mounts instead. Until (if ever) it makes it to a release, a
> local patch in pkgsrc would be nice.
>
> What about using mount(8) instead? Not every system has /proc mounted...
>
> Joerg
>
>
--
Joern Clausen
https://www.oe-files.de/photography/
--00000000000066113105ac2fa704
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div>Feel free to provide a better solution.</div><div><br=
></div><div>
<div>I have a) no skills in programming Python and b) no knowledge of=20
the inner workings of ansible (or the desire to learn them). The current
code is 3 years old, and already uses /proc/cpuinfo and /proc/meminfo,=20
so this is just a normalization of what is already there.</div>
</div></div><br><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_=
attr">On Wed, Aug 5, 2020 at 10:45 PM Joerg Sonnenberger <<a href=3D"mai=
lto:joerg%bec.de@localhost">joerg%bec.de@localhost</a>> wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex">The following reply was made to PR pkg/55544;=
it has been noted by GNATS.<br>
<br>
From: Joerg Sonnenberger <<a href=3D"mailto:joerg%bec.de@localhost"; target=3D"_bla=
nk">joerg%bec.de@localhost</a>><br>
To: <a href=3D"mailto:gnats-bugs%netbsd.org@localhost"; target=3D"_blank">gnats-bugs@n=
etbsd.org</a><br>
Cc: <br>
Subject: Re: pkg/55544: sysutils/ansible: use /proc/mounts<br>
Date: Wed, 5 Aug 2020 22:40:01 +0200<br>
<br>
=C2=A0On Wed, Aug 05, 2020 at 07:35:00PM +0000, <a href=3D"mailto:joernc@gm=
ail.com" target=3D"_blank">joernc%gmail.com@localhost</a> wrote:<br>
=C2=A0> >Number:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A055544<br>
=C2=A0> >Category:=C2=A0 =C2=A0 =C2=A0 =C2=A0pkg<br>
=C2=A0> >Synopsis:=C2=A0 =C2=A0 =C2=A0 =C2=A0sysutils/ansible: use /p=
roc/mounts<br>
=C2=A0> >Confidential:=C2=A0 =C2=A0no<br>
=C2=A0> >Severity:=C2=A0 =C2=A0 =C2=A0 =C2=A0serious<br>
=C2=A0> >Priority:=C2=A0 =C2=A0 =C2=A0 =C2=A0medium<br>
=C2=A0> >Responsible:=C2=A0 =C2=A0 pkg-manager<br>
=C2=A0> >State:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 open<br>
=C2=A0> >Class:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 sw-bug<br>
=C2=A0> >Submitter-Id:=C2=A0 =C2=A0net<br>
=C2=A0> >Arrival-Date:=C2=A0 =C2=A0Wed Aug 05 19:35:00 +0000 2020<br>
=C2=A0> >Originator:=C2=A0 =C2=A0 =C2=A0Joern Clausen<br>
=C2=A0> >Release:=C2=A0 =C2=A0 =C2=A0 =C2=A0 <br>
=C2=A0> >Organization:<br>
=C2=A0> >Environment:<br>
=C2=A0> >Description:<br>
=C2=A0> The fact gathering code for NetBSD already uses /proc in some ca=
ses, but reads /etc/fstab to find mounted filesystems. This misses usually =
(well, at least in my case) ZFS mounts, which are no longer documented ther=
e.<br>
=C2=A0> <br>
=C2=A0> >How-To-Repeat:<br>
=C2=A0> $ ansible foo -m setup<br>
=C2=A0> <br>
=C2=A0> will not report mounts on foo except those documented in /etc/fs=
tab<br>
=C2=A0> >Fix:<br>
=C2=A0> <a href=3D"https://github.com/ansible/ansible/pull/71113"; rel=3D=
"noreferrer" target=3D"_blank">https://github.com/ansible/ansible/pull/7111=
3</a> is a pull request to read /proc/mounts instead. Until (if ever) it ma=
kes it to a release, a local patch in pkgsrc would be nice.<br>
<br>
=C2=A0What about using mount(8) instead? Not every system has /proc mounted=
...<br>
<br>
=C2=A0Joerg<br>
<br>
</blockquote></div><br clear=3D"all"><br>-- <br><div dir=3D"ltr" class=3D"g=
mail_signature">Joern Clausen<br><a href=3D"https://www.oe-files.de/photogr=
aphy/" target=3D"_blank">https://www.oe-files.de/photography/</a></div>
--00000000000066113105ac2fa704--
Home |
Main Index |
Thread Index |
Old Index