Re: pkg/55487: samba4 fails to build due to unknown waf configure argument

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

The following reply was made to PR pkg/55487; it has been noted by GNATS.

From: Patrick Welche <prlw1%cam.ac.uk@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/55487: samba4 fails to build due to unknown waf configure
 argument
Date: Fri, 14 Aug 2020 16:34:55 +0100

 On Tue, Jul 14, 2020 at 10:40:01AM +0000, nfisher.sr%gmail.com@localhost wrote:
 >  I tracked it to devel/gmp/builtin.mk being included. I'm still not sure
 >  where it's being pulled in, but I temporarily commented out the
 >  CONFIGURE_ARGS+= lines in that file and they no longer appeared in the
 >  "waf configure" command line.
 
 I think you are right, and the CONFIGURE_ARGS lines in devel/gmp/builtin.mk
 should be removed.
 
 It is the package which depends on gmp which has to deal with
 a --with-gmp-include flag.
 
 Case in point: you hit this with samba, which depends on gnutls, which
 depends on gmp. samba doesn't have a use for --with-gmp-include, but
 neither does gnutls which even uses configure (as opposed to waf):
 
 # pwd
 /tmp/pkgsrc/security/gnutls/work.x86_64/gnutls-3.6.14
 # ./configure --help | grep -i gmp
   --with-nettle-mini      Link against a mini-nettle (that includes mini-gmp)
   GMP_CFLAGS  C compiler flags for gmp
   GMP_LIBS    linker flags for gmp
 # ./configure --with-gmp-include 2>&1 | more
 configure: WARNING: unrecognized options: --with-gmp-include
 checking build system type... x86_64-unknown-netbsd9.99
 ...
 
 It seems that packages like print/luatex, lang/ghc* already do the
 right thing.
 
 Second opinions?