pkg/55593: Proposed modification to buildlink3.mk of libxml2

[you.kawasaki%gmail.com@localhost]

>Number:         55593
>Category:       pkg
>Synopsis:       Proposed modification to buildlink3.mk of libxml2
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 20 03:40:00 +0000 2020
>Originator:     Yosuke Kawasaki
>Release:        pkgsrc-2020Q2
>Organization:
None
>Environment:
Linux 4.19.0-10-amd64 #1 SMP Debian 4.19.132-1 (2020-07-24) x86_64 GNU/Linux

>Description:
When I tried to compile multimedia/handbrake 1.3.1nb4, it failed to find libxml2 headers.

The exact error message is as follows.

/var/pkg/work/multimedia/handbrake/work/.cwrapper/bin/cc -std=gnu99 -pipe -fmessage-length=0 -Wall -Wno-format-truncation -g0 -O3 -O2 -D_GNU_SOURCE -I/usr/pkg/include/libxml2 -D_FORTIFY_SOURCE=2 -I/var/pkg/include -I/usr/include -I/var/pkg/include/glib-2.0 -I/var/pkg/include/gio-unix-2.0 -I/var/pkg/lib/glib-2.0/include -I/var/pkg/include/freetype2 -I/var/pkg/include/libdrm -I/var/pkg/include -I/usr/include -I/var/pkg/include/glib-2.0 -I/var/pkg/include/gio-unix-2.0 -I/var/pkg/lib/glib-2.0/include -I/var/pkg/include/freetype2 -I/var/pkg/include/libdrm -mfpmath=sse -msse2 -D__LIBHB__ -DUSE_PTHREAD -DSYS_LINUX -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DHAS_STRERROR_R -DARCH_X86_64 -I./libhb/ -I./contrib/include -I/usr/include/libxml2 -c ../libhb/vfr.c -o libhb/vfr.o
../libhb/plist.c:15:10: fatal error: libxml/parser.h: No such file or directory
 #include "libxml/parser.h"
          ^~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [../libhb/module.rules:12: libhb/plist.o] Error 1
make: *** Waiting for unfinished jobs....
*** Error code 2

Stop.
bmake[1]: stopped in /var/pkgsrc/pkgsrc-2020Q2/multimedia/handbrake
*** Error code 1

Stop.
bmake: stopped in /var/pkgsrc/pkgsrc-2020Q2/multimedia/handbrake



I noticed that the CFLAG does not include "include/libxml2".
When I added following line in buildlink3.mk of libxml2 to include "include/libxml2" in the CFLAG, building finished without an error for handbrake.

BUILDLINK_CFLAGS.libxml2+=    -I${BUILDLINK_PREFIX.libxml2}/include/libxml2

I thus propose adding the above line in buildlink3.mk of libxml2.

Yosuke
>How-To-Repeat:
Build handbrake 1.3.1nb4.
>Fix:
Add following line to buildlink3.mk of libxml2

BUILDLINK_CFLAGS.libxml2+=    -I${BUILDLINK_PREFIX.libxml2}/include/libxml2