Re: pkg/55989: archivers/zstd depends on coreutils

[Niclas Rosenvik <nros%NetBSD.org@localhost>]

The following reply was made to PR pkg/55989; it has been noted by GNATS.

From: Niclas Rosenvik <nros%NetBSD.org@localhost>
To: nia <nia%NetBSD.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost, pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 pkgsrc-bugs%netbsd.org@localhost, Thomas Klausner <wiz%NetBSD.org@localhost>
Subject: Re: pkg/55989: archivers/zstd depends on coreutils
Date: Thu, 11 Feb 2021 11:33:55 +0100

 On Thu, 11 Feb 2021 09:55:01 +0000 (UTC)
 nia <nia%NetBSD.org@localhost> wrote:
 
 
 >  I suspect the output format needs to match coreutils (hash -
 > filename) 
 
 >The problem is just the different output format of the different md5
 >tools.
 >  Thomas
 
 I see your point. But looking at the code where it is used and it looks
 like this:
 HASH_DIR = conf_$(shell echo $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) $(LDLIBS) $(ZSTD_FILES) | $(HASH) | cut -f 1 -d " ")
 
 I have tried with:
 
 echo 1 | digest md5 | cut -f 1 -d " "
 echo 1 | gmd5sum | cut -f 1 -d " "
 
 and they give the same result. Taking away the cut command gives the
 checksum with a dash in the end when using gmd5sum. So I think he
 actually wants the output that digest md5 gives. It should
 be safe to use it IMHO unless the above command changes in the future.
 also
 HAVE_HASH :=$(shell echo 1 | $(HASH) > /dev/null && echo 1 || echo 0)
 works correctly with digest md5 giving 1