Re: pkg/56186: libarchive: fix dirfd() check

[nia <nia%NetBSD.org@localhost>]

The following reply was made to PR pkg/56186; it has been noted by GNATS.

From: nia <nia%NetBSD.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/56186: libarchive: fix dirfd() check
Date: Fri, 21 May 2021 06:41:31 +0000

 On Thu, May 20, 2021 at 08:05:01PM +0000, Lehel Bernadt (lbernadt) wrote:
 >  My impression was that this is a pkgsrc/NetBSD helper lib, that's why I did=
 >  =20
 >  report the issue here and not upstream. I have a few workarounds in mk.conf=
 >  ,=20
 >  so it's not a problem to add another one; this just seemed a trivial change=
 >   to=20
 >  the configure script.
 >  
 >  Regards,
 >  Lehel=
 
 You don't need to add anything to mk.conf, we can add it to the
 pkgsrc Makefile.
 
 autotools allows overriding the result of configure tests, that's
 one of its advantages.
 
 In pkgsrc, we can also add OS-specific overrides, e.g.
 
 CONFIGURE_ENV.SunOS+=   ac_cv_func_epoll_create=no
 CONFIGURE_ENV.SunOS+=   ac_cv_func_epoll_ctl=no
 CONFIGURE_ENV.SunOS+=   ac_cv_func_epoll_wait=no
 
 This sets a specific variable in the generated ./configure script
 so its result will be "cached" (already set).
 
 This _should_ be fixed in pkgsrc, IMO, libarchive is an essential
 library. My reply did not mean "fix it locally yourself", but rather
 that it should be fixed in pkgsrc in a different way.