pkg/56502: ffmpegthumbnailer fails to build due to missing glib symbols

[pekdon%gmail.com@localhost]

>Number:         56502
>Category:       pkg
>Synopsis:       ffmpegthumbnailer fails to build due to missing glib symbols
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 16 07:20:00 +0000 2021
>Originator:     Claes Nästén
>Release:        trunk 2021-11-02
>Organization:
>Environment:
SunOS 5.10 i86pc i386 i86pc

>Description:
ffmpegthumbnailer fails to build on Solaris 10 due to missing symbols referenced by harfbuzz:

[ 77%] Linking C executable ffmpegthumbnailerctest
Undefined                       first referenced
 symbol                             in file
g_unicode_script_to_iso15924        /usr/pkg/lib/libharfbuzz.so.0
g_bytes_unref                       /usr/pkg/lib/libharfbuzz.so.0
g_unichar_compose                   /usr/pkg/lib/libharfbuzz.so.0
g_unichar_get_script                /usr/pkg/lib/libharfbuzz.so.0
g_bytes_ref                         /usr/pkg/lib/libharfbuzz.so.0
g_unichar_decompose                 /usr/pkg/lib/libharfbuzz.so.0
g_bytes_get_data                    /usr/pkg/lib/libharfbuzz.so.0
g_unichar_combining_class           /usr/pkg/lib/libharfbuzz.so.0
g_unicode_script_from_iso15924      /usr/pkg/lib/libharfbuzz.so.0
ld: fatal: symbol referencing errors. No output written to ffmpegthumbnailerctest
collect2: error: ld returned 1 exit status
--- test/ffmpegthumbnailerctest ---
*** [test/ffmpegthumbnailerctest] Error code 1

From my investigations it is caused by ffmpeg4 buildlink3.mk not including libass buildlink3.mk if the option is enabled.
>How-To-Repeat:
Build ffmpegthumbnailer on Solaris 10 with ffmpeg4 options:

ass av1 fontconfig freetype gnutls lame libvpx
libwebp opus speex theora vorbis x11 x264
x265

>Fix:
--- multimedia/ffmpeg4/buildlink3.mk.orig       Mon Nov 15 14:24:04 2021
+++ multimedia/ffmpeg4/buildlink3.mk    Mon Nov 15 14:23:39 2021
@@ -14,6 +14,10 @@
 
 .include "../../mk/bsd.fast.prefs.mk"
 
+.if ${PKG_BUILD_OPTIONS.ffmpeg4:Mass}
+.  include "../../multimedia/libass/buildlink3.mk"
+.endif
+
 .if ${PKG_BUILD_OPTIONS.ffmpeg4:Mav1}
 .  include "../../multimedia/libaom/buildlink3.mk"
 .endif