Re: pkg/56225: zstd compile issues on Solaris 10

[Claes Nästén <pekdon%gmail.com@localhost>]

The following reply was made to PR pkg/56225; it has been noted by GNATS.

From: =?utf-8?q?Claes_N=C3=A4st=C3=A9n?= <pekdon%gmail.com@localhost>
To: gnats-bugs <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: pkg/56225: zstd compile issues on Solaris 10
Date: Tue, 30 Nov 2021 17:46:37 +0100

 Excerpts from Jonathan Perkin's message of 2021-06-03 10:30:02 +0000:
 > The following reply was made to PR pkg/56225; it has been noted by GNATS.
 > 
 > From: Jonathan Perkin <jperkin%joyent.com@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost,
 >     pekdon%gmail.com@localhost
 > Subject: Re: pkg/56225: zstd compile issues on Solaris 10
 > Date: Thu, 3 Jun 2021 11:28:24 +0100
 > 
 >  * On 2021-06-03 at 10:54 BST, Claes N�st�n wrote:
 >  
 >  > Assuming it could have something to do with gmake calling /bin/sh
 >  > directly for its commands?
 >  >
 >  > As in:
 >  >
 >  > $ strings /usr/pkg/bin/gmake |ggrep '\bsh\b'
 >  > /bin/sh
 >  
 >  Yeh we should probably fix this.  gmake honours SHELL but I don't think 
 >  we always set that in the build environment, so we should patch out 
 >  default_shell to be ${SH}.
 >  
 
 A simple change as this fixes the install of zstd on Solaris 10 for, have
 noticed some other packages such as QT5 requiring this as well.
 
 --- Makefile.orig       Tue Nov 23 21:04:01 2021                                
 +++ Makefile    Tue Nov 23 17:22:49 2021                                        
 @@ -21,6 +21,7 @@                                                               
  USE_TOOLS+=            perl:test                                               
                                                                                 
  CONFIGURE_ARGS+=       --program-prefix=g                                      
 +CPPFLAGS+=             -DPKGSRC_DEFAULT_SHELL=\"${SH}\"                        
                                                                                 
  # workaround for broken strndup                                                
  CONFIGURE_ARGS.MirBSD+=        ac_cv_func_strndup=no                           
                                                                                 
                                                                                 
 --- src/job.c.orig      2021-11-23 16:20:03.622007892 +0000                     
 +++ src/job.c                                                                   
 @@ -77,7 +77,7 @@ char * vms_strsignal (int status);                            
                                                                                 
  #else                                                                          
                                                                                 
 -const char *default_shell = "/bin/sh";                                         
 +const char *default_shell = PKGSRC_DEFAULT_SHELL;                              
  int batch_mode_shell = 0;                                                      
                                                                                 
  #endif