pkg/56627: net/tigervnc fails to build on Solaris 11.3 due to missing -lsocket -lnsl linker flags

[cryintothebluesky%gmail.com@localhost]

>Number:         56627
>Category:       pkg
>Synopsis:       net/tigervnc fails to build on Solaris 11.3 due to missing -lsocket -lnsl linker flags
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jan 14 15:20:00 +0000 2022
>Originator:     Sad Clouds
>Release:        pkgsrc-2021Q4
>Organization:
>Environment:
SunOS pkgsrc 5.11 11.3 sun4v sparc SUNW,SPARC-Enterprise-T5220
>Description:
Looks like gai_strerror() needs "-lsocket -lnsl" which is not used during build process, hence undefined symbol errors.

[ 92%] Built target convertlf
[ 93%] Linking CXX executable convperf
Undefined                       first referenced
 symbol                             in file
gai_strerror                        ../../common/rdr/librdr.a(Exception.cxx.o)  (symbol belongs to implicit dependency /lib/sparcv9/libsocket.so.1)
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
gmake[2]: *** [tests/unit/CMakeFiles/pixelformat.dir/build.make:104: tests/unit/pixelformat] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:1100: tests/unit/CMakeFiles/pixelformat.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....

I modified pkg Makefile LDFLAGS, as a quick fix, but this is not suitable for all platforms and may need to added conditionally.

LDFLAGS+=       ${BUILDLINK_LDADD.gettext} -lsocket -lnsl

This builds it successfully, but then I get install error due to missing pam files:

/usr/bin/mv /opt/netbsd/pkg.objects/net/tigervnc/work.pkgsrc/.destdir/opt/pkg/etc/pam.d/tigervnc /opt/netbsd/pkg.objects/net/tigervnc/work.pkgsrc/.destdir/opt/pkg/share/examples/tigervnc
mv: cannot access /opt/netbsd/pkg.objects/net/tigervnc/work.pkgsrc/.destdir/opt/pkg/etc/pam.d/tigervnc
*** Error code 2

There is no etc/pam.d generated on Solaris. This probably needs to be conditionally excluded from Makefile post-install.
# ls -l /opt/netbsd/pkg.objects/net/tigervnc/work.pkgsrc/.destdir/opt/pkg
total 18
drwxr-xr-x   2 root     root           8 Jan 14 15:57 bin
drwxr-xr-x   4 root     root           4 Jan 14 15:57 lib
drwxr-xr-x   2 root     root           4 Jan 14 15:57 libexec
drwxr-xr-x   4 root     root           4 Jan 14 15:57 man
drwxr-xr-x   2 root     root           3 Jan 14 15:57 sbin
drwxr-xr-x   7 root     root           7 Jan 14 15:57 share
>How-To-Repeat:

>Fix: