Re: pkg/53753: gcc8 fails to build on Solaris 10

[Claes Nästén <pekdon%gmail.com@localhost>]

The following reply was made to PR pkg/53753; it has been noted by GNATS.

From: =?UTF-8?B?Q2xhZXMgTsOkc3TDqW4=?= <pekdon%gmail.com@localhost>
To: gnats-bugs <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: pkg/53753: gcc8 fails to build on Solaris 10
Date: Fri, 21 Jan 2022 07:39:32 +0100

 I have GCC 8 building fine on my system, requires  #56493 to be fixed
 and a patch along the lines of:
 
 diff --git a/lang/gcc8/Makefile b/lang/gcc8/Makefile
 index f5bc83ffe66..63c59a0e64d 100644
 --- a/lang/gcc8/Makefile
 +++ b/lang/gcc8/Makefile
 @@ -152,22 +152,27 @@ MAKE_ENV+=                lt_cv_path_SED=${TOOLS_SED}
 
  # Determine whether to use binutils
  .if ${OPSYS} == "SunOS"
 -.  if exists(/usr/sfw/bin/gobjdump)
 -CONFIGURE_ENV+=                OBJDUMP=/usr/sfw/bin/gobjdump
 -.  endif
  .  if exists(/usr/bin/ld)
  CONFIGURE_ARGS+=       --without-gnu-ld --with-ld=/usr/bin/ld
 -.  else
 +.  elif exists(/usr/ccs/bin/ld)
  CONFIGURE_ARGS+=       --without-gnu-ld --with-ld=/usr/ccs/bin/ld
 +.  elif
 +REQUIRE_BINUTILS=yes
 +CONFIGURE_ARGS+=       --with-gnu-ld --with-ld=${PREFIX}/bin/gld
  .  endif
 -.  if exists(/usr/sfw/bin/gas)
 -CONFIGURE_ARGS+=       --with-gnu-as --with-as=/usr/sfw/bin/gas
 -.  elif exists(/usr/ccs/bin/as)
 +
 +.  if ${OS_VARIANT} != "Solaris" && exists(/usr/ccs/bin/as)
  CONFIGURE_ARGS+=       --without-gnu-as --with-as=/usr/ccs/bin/as
  .  else
 +REQUIRE_BINUTILS=yes
 +CONFIGURE_ARGS+=       --with-gnu-as --with-as=${PREFIX}/bin/gas
 +.  endif
 +
 +.  if ${REQUIRE_BINUTILS} == "yes"
  BUILDLINK_DEPMETHOD.binutils=  full
  .    include "../../devel/binutils/buildlink3.mk"
 -CONFIGURE_ARGS+=       --with-gnu-as --with-as=${PREFIX}/bin/gas
 +CONFIGURE_ARGS+=       OBJDUMP=${PREFIX}/bin/gobjdump
 +CONFIGURE_ARGS+=       OBJCOPY=${PREFIX}/bin/gobjcopy
  .  endif
  .endif
 
 This is somewhat tweaked from what I have used myself, but attempting
 to avoid issues
 on non Solaris SunOS variants.
 
 Reason behind always using gas instead of ccs as is that ccs as isn't
 supporting all modern
 instructions used today.