pkg/56716: bind916 - socket.c - remove _XOPEN_SOURCE from patch

[russhan%gmail.com@localhost]

>Number:         56716
>Category:       pkg
>Synopsis:       bind916 - socket.c - remove _XOPEN_SOURCE from patch
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 15 17:30:00 +0000 2022
>Originator:     Russell Hansen
>Release:        pkgsrc-upstream-trunk SmartOS 20201203T165910Z/x86_64 2022-02-13 22:56
>Organization:
>Environment:
SunOS  5.11 joyent_20201203T165910Z i86pc i386 i86pc
>Description:
I submitted https://github.com/NetBSD/pkgsrc/issues/100 but it looks like this place is the proper location to submit issues.

net/bind916/patches/patch-lib_isc_unix_socket.c appears to have lost the definition of _XOPEN_SOURCE required for SmartOS.

Specifically I believe this might be the culprit:
https://github.com/NetBSD/pkgsrc/commit/ce4a3bfab2e65388e88328625273ab7bdc6e5d3e#diff-1285c7d3bbb0e62c17003e1f8bccc791851efd65b4cf340c3f24f69bc6b8099a

The consequence can be found at:
http://mail-index.netbsd.org/pkgsrc-bulk/2022/02/14/msg022049.html
https://us-east.manta.joyent.com/pkgsrc/public/reports/upstream-trunk/20220213.2256/bind-9.16.25/build.log

net/bind916/patches/patch-lib_isc_unix_net.c does have the included _XOPEN_SOURCE definition.

>How-To-Repeat:
I'm simply following the SmartOS bulk build results.

http://mail-index.netbsd.org/pkgsrc-bulk/
>Fix:
I believe the following block needs to be restored:

#if defined(__sun)
#if (__STDC_VERSION__ - 0 < 199901L)
#define _XOPEN_SOURCE 500
#else
#define _XOPEN_SOURCE 600
#endif
#endif

I'm not very familiar with C for how to generate a diff and submit a change request, I'm just trying to follow the logic.