Re: pkg/56747: textproc/py-libxml2 fails with python310

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

The following reply was made to PR pkg/56747; it has been noted by GNATS.

From: "David H. Gutteridge" <david%gutteridge.ca@localhost>
To: John Klos <john%ziaspace.com@localhost>, Gnats Bugs <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: pkg/56747: textproc/py-libxml2 fails with python310
Date: Mon, 14 Mar 2022 22:39:01 -0400

 On 2022-03-14 15:14, John Klos wrote:
 > On six or so systems:
 > 
 > python310-3.10.2
 > py310-setuptools-60.9.3
 > 
 > On one system:
 > 
 > python39-3.9.10
 > py39-setuptools-60.9.3
 > 
 > Perhaps mk/subst.mk doesn't gracefully handle instances where the 
 > substitution isn't necessary, like where LOCALBASE is already 
 > /usr/local. It couldn't be that simple, could it?
 
 Yes, I think that's very likely what's happening here. Could you please
 try the following patch?
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/textproc/py-libxml2/Makefile,v
 retrieving revision 1.78
 diff -u -r1.78 Makefile
 --- Makefile	12 Mar 2022 07:33:22 -0000	1.78
 +++ Makefile	15 Mar 2022 02:35:18 -0000
 @@ -16,6 +16,7 @@
   SUBST_MESSAGE.setup=	Fixing hardcoded paths.
   SUBST_STAGE.setup=	pre-build
   SUBST_FILES.setup=	python/setup.py
 +SUBST_NOOP_OK.setup=	yes
   SUBST_SED.setup=	-e 
 "/ROOT/s,'/usr/local','${BUILDLINK_PREFIX.libxml2}',g"
   SUBST_SED.setup+=	-e 
 "/^\"/s,/usr/include,${BUILDLINK_PREFIX.iconv}/include,g"
   SUBST_SED.setup+=	-e 
 "/^\"/s,/usr/local/include,${BUILDLINK_PREFIX.iconv}/include,g"
 
 Dave