Re: pkg/56924: Many packages ignore package specific MAKE_JOBS overrides

[David Holland <dholland-pbugs%netbsd.org@localhost>]

On Thu, Jul 14, 2022 at 07:20:00AM +0000, stix%stix.id.au@localhost wrote:
 > Many packages reference MAKE_JOBS in their makefiles, eg:
 > 
 > ksh$ grep MAKE_JOBS x11/qt5-qtwebengine/Makefile
 > MAKE_ENV+=      NINJAJOBS="-j ${MAKE_JOBS:U1}"

For ninja and other build tools I would think that this ought to
happen somewhere in the infrastructure, not in every package. But I
suppose there isn't any such place currently.

 > However, if setting a manual override in mk.conf:
 > 
 > MAKE_JOBS.x11/qt5-qtwebengine=4
 > 
 > the override is ignored, and the default used. Substituting _MAKE_JOBS_N
 > for MAKE_JOBS works, and is used in many other packages, eg:
 > 
 > ksh$ grep _MAKE_JOBS_N devel/cmake/Makefile
 > CONFIGURE_ARGS+=        --parallel=${_MAKE_JOBS_N:U1}
 > 
 > but this (I believe) is supposed to be an internal variable.

Yes, the right way is for the infrastructure to compute a variable
PKG_MAKE_JOBS and then for packages to use that.

 > See possible patch referenced in the mail thread above:
 > https://gist.github.com/jperkin/b390f0d922e5c22430ae7f2d8131a158

...why didn't that get committed?

-- 
David A. Holland
dholland%netbsd.org@localhost