pkg/57012: squirrelmail compatibility problem with php 8

[Hauke Fath <hf%spg.tu-darmstadt.de@localhost>]

>Number:         57012
>Category:       pkg
>Synopsis:       squirrelmail compatibility problem with php 8
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 15 10:45:00 +0000 2022
>Originator:     Hauke Fath
>Release:        NetBSD 9.3_STABLE
>Organization:
Technische Universitaet Darmstadt
>Environment:
	
	
System: NetBSD Hochobir 9.3_STABLE NetBSD 9.3_STABLE (DMZ_DOMU) #0: Thu Aug 18 16:51:33 CEST 2022 hf@Hochstuhl:/var/obj/netbsd-builds/9/amd64/sys/arch/amd64/compile/DMZ_DOMU amd64
Architecture: x86_64
Machine: amd64
>Description:

	When built with PHP 8.1, ending mail in squirrelmail will not
	file a copy in the Sent folder, even if configured to do so.

	Instead, the web server logs several warnings, and then an
	error:

[Wed Sep 14 18:35:39.016448 2022] [php:error] [pid 5847] [client x.x.x.x:52912] PHP Fatal error:  Declaration of Deliver_IMAP::send_mail($message, $header, $boundary, $stream, &$raw_length, $folder = null) must be compatible with Deliver::send_mail($message, $header, $boundary, $stream = false, &$raw_length = 0, $extra = null) in /usr/pkg/share/squirrelmail/class/deliver/Deliver_IMAP.class.php on line 54, referer: https://www2.nt.tu-darmstadt.de/squirrelmail/src/compose.php?mailbox=INBOX&startMessage=1


	
>How-To-Repeat:

	Install mail/squirrelmail with PHP 8.1, send a mail. Find
	there is no copy in Sent folder.

	
>Fix:
	

	I understand that the package distfile is a svn snapshot
	stored on netbsd.org:

1.141 (taca 21-Mar-21): DISTNAME=squirrelmail-webmail-1.4.23pre14904
1.122 (taca 28-Dec-12): MASTER_SITES=${MASTER_SITE_LOCAL}

	Upstream makes it sound like php 8 compatibility issues were
	fixed, so the snapshot should probably be updated.

>Unformatted: