pkg/57045: graphics/cairo-gobject misses X11 libraries

[mike.volokhov%gmail.com@localhost]

>Number:         57045
>Category:       pkg
>Synopsis:       graphics/cairo-gobject misses X11 libraries
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 05 22:05:00 +0000 2022
>Originator:     Mike Volokhov
>Release:        pkgsrc-2022q3
>Organization:
>Environment:
Darwin MacBook 19.6.0 Darwin Kernel Version 19.6.0: Mon Aug 31 22:12:52 PDT 2020; root:xnu-6153.141.2~1/RELEASE_X86_64 x86_64
>Description:
Hi!

The graphics/cairo-gobject can't be built on a macOS (perhaps other systems are affected) with modular x11 due to missing Xlib. It fails with the following error during the configure stage:

checking whether cairo's Xlib surface backend feature could be enabled... no (requires X development libraries)
configure: error:  Xlib surface backend feature could not be enabled
*** Error code 1

Stop.
bmake[1]: stopped in /Users/mishka/pkgsrc/graphics/cairo-gobject
WARNING: *** Please consider adding c++ to USE_LANGUAGES in the package Makefile.
*** Error code 1

Stop.
bmake: stopped in /Users/mishka/pkgsrc/graphics/cairo-gobject
>How-To-Repeat:
Try to build the cairo-gobject package on Darwin with modular xorg.
>Fix:
Buildlinking the X11 libraries seem can fix the issue.
# $NetBSD: Makefile,v 1.40 2021/12/08 16:02:07 adam Exp $

--- Makefile.orig	2022-10-06 00:52:41.000000000 +0300
+++ Makefile	2022-10-06 00:52:59.000000000 +0300
@@ -25,6 +25,9 @@
 .if !empty(PKG_BUILD_OPTIONS.cairo:Mx11) || !empty(PKG_BUILD_OPTIONS.cairo:Mxcb)
 CONFIGURE_ARGS+=	--enable-xlib
 CONFIGURE_ARGS+=	--enable-xlib-xrender
+.  include "../../x11/libX11/buildlink3.mk"
+.  include "../../x11/libXext/buildlink3.mk"
+.  include "../../x11/libXrender/buildlink3.mk"
 .  if !empty(PKG_BUILD_OPTIONS.cairo:Mxcb)
 CONFIGURE_ARGS+=	--enable-xcb
 .  else