Re: pkg/57047: Xine-ui can't be built without "inline-all-stringops" __attribute (aarch64)

[adr <adr%SDF.ORG@localhost>]

On Sat, 8 Oct 2022, David Holland wrote:

> Date: Sat,  8 Oct 2022 02:50:01 +0000 (UTC)
> From: David Holland <dholland-pbugs%netbsd.org@localhost>
> Reply-To: gnats-bugs%netbsd.org@localhost
> To: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost,
>     adr%sdf.org@localhost
> Subject: Re: pkg/57047: Xine-ui can't be built without "inline-all-stringops"
>     __attribute (aarch64)
>
> The following reply was made to PR pkg/57047; it has been noted by GNATS.
>
> From: David Holland <dholland-pbugs%netbsd.org@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Cc:
> Subject: Re: pkg/57047: Xine-ui can't be built without "inline-all-stringops"
> __attribute (aarch64)
> Date: Sat, 8 Oct 2022 02:49:14 +0000
>
> On Thu, Oct 06, 2022 at 09:35:01AM +0000, adr%sdf.org@localhost wrote:
>  >  #ifndef HAVE_STRLCPY
>  > +#ifdef ATTR_INLINE_ALL_STRINGOPS
>  >  size_t strlcpy (char *dst, const char *src, size_t size) ATTR_INLINE_ALL_STRINGOPS;
>  > +#else
>  > +size_t strlcpy (char *dst, const char *src, size_t size);
>  > +#endif
>  >  #endif
>
> Surely it's sufficient to pass "-DATTR_INLINE_ALL_STRINGOPS="?

Sure, but then ATTR_INLINE_ALL_STRINGOPS will be defined. I think
that could be problematic in the future. The best option for me is
include those patches so xine can be built in all archs on netbsd
and contact upstream so they rework the code. Just my opinion.

adr