pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/57062: master is not a valid tag name, use an explicit commit hash



The following reply was made to PR pkg/57062; it has been noted by GNATS.

From: Benny Siegert <bsiegert%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: pkg-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/57062: master is not a valid tag name, use an explicit commit hash
Date: Mon, 17 Oct 2022 18:32:42 +0200

 On Mon, Oct 17, 2022 at 5:40 PM <andrew.cagney%gmail.com@localhost> wrote:
 > It should be updated, or perhaps replaced by documentation explaining that it really needs to be a "tag" (hence the suffix) and not a branch.
 >
 > (I suspect adding GITHUB_TAG=main NO_CHECKSUM=yes to the package Makefile is frowned upon)
 
 Well, the message already says it should be a commit hash. A commit
 hash refers to a single given commit. Putting in a branch is asking
 for all kinds of trouble.
 
 That said, the code should probably also recognize main instead of master.
 
 -- 
 Benny
 


Home | Main Index | Thread Index | Old Index