pkg/57201: audio/libsndfile building failure for PREFER_PKGSRC=yes

[triaxx%netbsd.org@localhost]

>Number:         57201
>Category:       pkg
>Synopsis:       audio/libsndfile building failure for PREFER_PKGSRC=yes
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 28 15:25:00 +0000 2023
>Originator:     Frédéric Fauberteau
>Release:        pkgsrc-2022Q4
>Organization:
>Environment:
System: NetBSD guardian.triaxx.org 9.99.106 NetBSD 9.99.106 (GUARDIAN) #2: Sun Nov 20 07:32:35 CET 2022  triaxx%guardian.triaxx.org@localhost:/usr/obj/sys/arch/amd64/compile/GUARDIAN amd64
Architecture: x86_64
Machine: amd64
>Description:
The building of audio/libsndfile fails with the following error:
|   CCLD     src/libcommon.la
|   CCLD     src/libsndfile.la
| 
| *** Warning: linker path does not have real file for library -lncurses.
| *** I have the capability to make that library automatically link in when
| *** you link to this library.  But I can only do this if you have a
| *** shared version of the library, which you do not appear to have
| *** because I did check the linker path looking for a file starting
| *** with libncurses and none of the candidates passed a file format test
| *** using a regex pattern. Last file checked: /usr/pkgsrc/audio/libsndfile/work/.buildlink/lib/libmp3lame.so
| *** The inter-library dependencies that have been dropped here will be
| *** automatically added whenever a program is linked with this library
| *** or is declared to -dlopen it.
| 
| *** Since this library must not contain undefined symbols,
| *** because either the platform does not support them or
| *** it was explicitly requested with -no-undefined,
| *** libtool will only create a static version of it.
|   CCLD     programs/sndfile-info
| ld: cannot find -lncurses
| *** Error code 1
| 
| Stop.
| bmake[2]: stopped in /usr/pkgsrc/audio/libsndfile/work/libsndfile-1.1.0
| *** Error code 1
| 
| Stop.
| bmake[1]: stopped in /usr/pkgsrc/audio/libsndfile/work/libsndfile-1.1.0
| *** Error code 1
| 
| Stop.
| bmake: stopped in /usr/pkgsrc/audio/libsndfile/work/libsndfile-1.1.0
| *** Error code 1
| 
| Stop.
| bmake[1]: stopped in /usr/pkgsrc/audio/libsndfile
| *** Error code 1
| 
| Stop.
| bmake: stopped in /usr/pkgsrc/audio/libsndfile

This occurs on a bootstrap with --prefer-pkgsrc=yes. Another bootstrap without preference on the same machine doesn't suffer from this issue.

The fix below solve the issue but I don't if HEAD suffers from it too.
>How-To-Repeat:
cd /usr/pkgsrc/bootstrap
./bootstrap --prefer-pkgsrc=yes
cd ../audio/libsndfile
bmake build
>Fix:
--- Makefile    11 Sep 2022 12:51:04 -0000      1.91
+++ Makefile    28 Jan 2023 15:14:30 -0000
@@ -40,4 +40,5 @@
 .include "../../lang/python/tool.mk"
 BUILDLINK_API_DEPENDS.libogg+= libogg>=1.1.3
 .include "../../multimedia/libogg/buildlink3.mk"
+.include "../../mk/terminfo.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"