Re: pkg/57274: libass package doesn't use optimised assembly

[Oneric <oneric%oneric.de@localhost>]

The following reply was made to PR pkg/57274; it has been noted by GNATS.

From: Oneric <oneric%oneric.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: Joerg Sonnenberger <joerg%bec.de@localhost>, pkgsrc-bugs%netbsd.org@localhost,
	pkg-manager%netbsd.org@localhost
Subject: Re: pkg/57274: libass package doesn't use optimised assembly
Date: Sun, 19 Mar 2023 00:28:08 +0100

 --M3bYekPTwVkRwt9G
 Content-Type: text/plain; charset=utf-8
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 On Sat, Mar 18, 2023 at 19:10:02 +0000, Joerg Sonnenberger wrote:
 >  Am Thu, Mar 16, 2023 at 05:15:00PM +0000 schrieb oneric%oneric.de@localhost:
 >  > By disabling replacement of libtool pkgsrc builds work as well; see ch=
 anges below.
 > =20
 >  Sounds worse than not using assembler. How much time is spend in a
 >  subtitle renderer anyway?
 
 Potentially a lot of time. ASS supports and is used for complex
 typesetting, with many simultaneous events, animations and blur.
 That=E2=80=99s why there is assembly in the first place (in git master now
 also for aarch64; this doesn't use NASM though).
 
 Good news however, with some more testing I was able to find out what=E2=80=
 =99s
 leading to the error: with replaced-libtool pkgsrc builds try to pass
 `-pie` to NASM which the latter does not understand and is not converted
 by libass=E2=80=99 ltnasm.sh.
 In manual builds from git (i.e. using the libtool installed from pkgsrc!)
 this does not happen and everything builds fine.
 
 libass patch to workaround this without disabling libtool-override down
 below. I should probably also relay this upstream. Do you know why -pie
 shows up only when pkgsrc replaces libtool? Is this specific to
 pkgsrc-builds or could it also happen elsewhere?
 
 
 diff --git a/ltnasm.sh b/ltnasm.sh
 index 92c3c42..e209363 100755
 --- a/ltnasm.sh
 +++ b/ltnasm.sh
 @@ -19,7 +19,7 @@ while [ "$#" -gt 0 ] ; do
          # C-compiler options will always use the latter.
          -f) cmd=3D"$cmd $1" ;;
          -f*) : ;;
 -        -DPIC) cmd=3D"$cmd -DPIC=3D1" ;;
 +        -DPIC|-pie) cmd=3D"$cmd -DPIC=3D1" ;;
          *) cmd=3D"$cmd $1" ;;
      esac
      shift
 
 --M3bYekPTwVkRwt9G
 Content-Type: application/pgp-signature; name="signature.asc"
 
 -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCAAdFiEE3a/BnkayrS1rJvhDl6CODP/XCVEFAmQWSP0ACgkQl6CODP/X
 CVFPeBAAgFZWE59q/uzVrnZs4U56icLy+ImAlWz3gMk/P5pTb5QA0PB6FEPJakyx
 TKvmJuhytzfCDKGxpD+Yf0oKSjcLOX9i/MqTCjtMZx6bJBKcYFoZ65XZsMoHJoYr
 IkjzN3I55MZeYXj3V5Kzc2gcp3iRfcrj2LZE1Bmn/8sSqL5/urO98Eeto4YBhh+s
 rJ2PTy4kNoZdmUBcJaWO6T3czjTpWqA7cZKWguNl1iO9a6WixFrh5F5j7w/t9B1g
 sz8fpK/eMs7f7S735D6pMKwQMbMwUZykPrRu6icwU6ghhqu1s1Ng1I3YKsFUXYvV
 sZqWNoL5zlcU92NrONZBaRoSUZaA9eZUVnpwnLunlBeBWKon3LRAof8/J3XcxOIu
 av9XVEPuAgijg/oA1KjyAlsDzOkhcprKVrdmjJlFfB3e+dzIiZnrQYNAOtZG9Oi3
 zHVMLzkEKLITBNpcVSdpdA5wmmVnDy7lH7cMRNs+HvkGweeZBaOLCeraGEmTHXLi
 iRLbQsrCpqPZ4w4eCrqXm4BtHWXw8Vnh91aVzlPiYRonwpXZYMd/m1gBhxkO7wXj
 8cNNqvCGs0YNlL++x6FEg203F6GwgLIWnHYmNdZq7BhmSbXGDuiuPmvg6EdwhHls
 udMLjT1SHlrM+nR3BOJM8OTqY/47Gqwd7cSv0TYoP8FzXMKqWKE=
 =Gtzt
 -----END PGP SIGNATURE-----
 
 --M3bYekPTwVkRwt9G--