pkg/57524: libheif build failure with svt-av1 on macOS

[triaxx%netbsd.org@localhost]

>Number:         57524
>Category:       pkg
>Synopsis:       libheif build failure with svt-av1 on macOS
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 13 07:10:00 +0000 2023
>Originator:     Frédéric Fauberteau
>Release:        Darwin 22.5.0
>Organization:
>Environment:
System: Darwin arbiter.local 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun  8 22:22:19 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T8103 arm64
Architecture: arm
Machine: arm64
Pkgsrc release: current
>Description:
graphics/libheif building fails when trying to link libheif-svtenc.so with the following message:
    [ 76%] Building CXX object libheif/plugins/CMakeFiles/heif-svtenc.dir/__/heif_plugin.cc.o
    [ 77%] Linking CXX shared module libheif-svtenc.so
    clang: error: invalid argument '-compatibility_version 1.0.0' only allowed with '-dynamiclib'
    --- libheif/plugins/libheif-svtenc.so ---
    *** [libheif/plugins/libheif-svtenc.so] Error code 1
>How-To-Repeat:
cd graphics/libheif && bmake build
>Fix:
To add -dynamiclib to flag makes the linking step successing but an error then occurs about missing relative library...

The following patch disables the SvtEnc plugin and fixes the issue:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/graphics/libheif/Makefile,v
retrieving revision 1.20
diff -u -r1.20 Makefile
--- Makefile    11 Jul 2023 22:36:43 -0000      1.20
+++ Makefile    13 Jul 2023 06:50:15 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.20 2023/07/11 22:36:43 abs Exp $

 DISTNAME=      libheif-1.16.2
-PKGREVISION=   1
+PKGREVISION=   2
 CATEGORIES=    graphics
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=strukturag/}
 GITHUB_PROJECT=        libheif
@@ -16,6 +16,7 @@
 USE_LANGUAGES= c c++

 CMAKE_CONFIGURE_ARGS+= -DWITH_RAV1E=OFF
+CMAKE_CONFIGURE_ARGS+= -DWITH_SvtEnc=OFF

 PKGCONFIG_OVERRIDE+=   libheif.pc.in

@@ -24,7 +25,6 @@
 .include "../../multimedia/dav1d/buildlink3.mk"
 .include "../../multimedia/libaom/buildlink3.mk"
 .include "../../multimedia/libde265/buildlink3.mk"
-.include "../../multimedia/svt-av1/buildlink3.mk"
 .include "../../multimedia/x265/buildlink3.mk"
 .include "../../mk/jpeg.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"