pkg/57557: audio/cdparanoia broken in macOS Ventura

[jdwhite%menelos.com@localhost]

>Number:         57557
>Category:       pkg
>Synopsis:       Always throws assertion unless displaying usage/help.
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 01 22:05:00 +0000 2023
>Originator:     Jason White
>Release:        Darwin 22.6.0
>Organization:
>Environment:
System: Darwin pkgbuild-x86.home.menelos.com 22.6.0 Darwin Kernel Version 22.6.0: Wed Jul 5 22:21:56 PDT 2023; root:xnu-8796.141.3~6/RELEASE_X86_64 x86_64

pkgsrc-current

>Description:
cdparanoia always throws this assertion:

  cdparanoia III release 10.2 (September 11, 2008)

  Using cdda library version: 10.2
  Using paranoia library version: 10.2
  Assertion failed: (range.location + range.length <= dataLength), function __CFDataValidateRange, file CFData.c, line 235.
  Abort trap: 6

>How-To-Repeat:
Compile, run with valid args such as '-Q --verbose'

>Fix:
https://trac.macports.org/ticket/66153

Patch the patch:

--- audio/cdparanoia/patches/patch-cn.old       2023-08-01 16:48:07
+++ audio/cdparanoia/patches/patch-cn   2023-08-01 16:35:23
@@ -153,7 +153,7 @@
 +    return -1;
 +  }
 +
-+  buf_len = CFDataGetLength(data) + 1;
++  buf_len = CFDataGetLength(data);
 +  range = CFRangeMake(0, buf_len);
 +
 +  d->raw_toc = (CDTOC *)malloc(buf_len);

Macports ticket claims to have tested on OSX Lion. Backward compatability
doesn't appear to be an issue.