pkg/57668: net/xymonclient PKGNAME and FILE_NAME breaks install via pkgin.

[jdwhite%menelos.com@localhost]

>Number:         57668
>Category:       pkg
>Synopsis:       Binary package name missing PKGREVISION
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 18 18:15:00 +0000 2023
>Originator:     Jason White
>Release:        Darwin 23.0.0
>Organization:
>Environment:
System: Darwin pkgbuild-x86 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:42:42 PDT 2023; root:xnu-10002.1.13~1/RELEASE_X86_64 x86_64

pkgsrc-current, last updated 2023-10-18 12:03 UTC

>Description:

When generating a binary package for net/xymonclient, the on-disk name of the 
package does not have the package revision. This causes pkgin(1) to fail when 
installing:

  # pkgin in xymonclient
  calculating dependencies...done.

  1 package to refresh:
    xymonclient-4.3.30nb1

  0 to remove, 1 to refresh, 0 to upgrade, 0 to install
  471K to download, 2672B of disk space will be freed up

  download error: https://XXXXXXXXXXXX/packages/Darwin/x86_64/14.0/All/xymonclient-4.3.30nb1.tgz Not Found

  pkgbuild_x86# pkg_info -X /opt/pkg/packages/Darwin/x86_64/14.0/All

  CONFLICTS=hobbitmon-[0-9]*
  CONFLICTS=hobbitclient-[0-9]*
  PKGNAME=xymonclient-4.3.30nb1
  DEPENDS=user-darwin>=20130712
  COMMENT=Network services monitor a la Big Brother
  SIZE_PKG=1446003
  BUILD_DATE=2023-10-18 08:38:16 -0500
  CATEGORIES=net
  HOMEPAGE=https://xymon.sourceforge.io/
  LICENSE=gnu-gpl-v2
  MACHINE_ARCH=x86_64
  OPSYS=Darwin
  OS_VERSION=23.0.0
  PKGPATH=net/xymonclient
  PKGTOOLS_VERSION=20091115
  FILE_NAME=xymonclient-4.3.30.tgz     <=== culprit?
  FILE_SIZE=482146
  DESCRIPTION=Xymon is the successor to (rename of) Hobbit which was the successor
  DESCRIPTION=to the bbgen toolkit, which had been available as an add-on to Big Brother
  DESCRIPTION=since late 2002.
  DESCRIPTION=
  DESCRIPTION=Xymon monitors your hosts, your network services, and anything else
  DESCRIPTION=you configure it to do via extensions. This is the client (agent) package.
  DESCRIPTION=
  DESCRIPTION=Homepage:
  DESCRIPTION=https://xymon.sourceforge.io/

net/xymonclient build output:

  net/xymonclient# bmake package
  [...]
  => Generating post-install file lists
  => Checking file-check results for xymonclient-4.3.30nb1
  => Creating binary package /opt/obj/pkg/net/xymonclient/work/.packages/xymonclient-4.3.30.tgz
                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^ -- no "nb1"
  ===> Building binary package for xymonclient-4.3.30nb1
  => Creating binary package /opt/pkg/packages/Darwin/x86_64/14.0/All/xymonclient-4.3.30.tgz
                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ -- no "nb1"
  ===> Installing binary package of xymonclient-4.3.30nb1
  ===> Installing binary package of xymonclient-4.3.30nb1
  xymonclient-4.3.30nb1: copying /opt/pkg/share/examples/xymon/clientlaunch.cfg to /opt/pkg/etc/xymon/clientlaunch.cfg
  xymonclient-4.3.30nb1: copying /opt/pkg/share/examples/xymon/localclient.cfg to /opt/pkg/etc/xymon/localclient.cfg
  xymonclient-4.3.30nb1: copying /opt/pkg/share/examples/xymon/xymonclient.cfg to /opt/pkg/etc/xymon/xymonclient.cfg
  ===========================================================================
  The following files should be created for xymonclient-4.3.30nb1:

          /opt/pkg/etc/rc.d/xymonclient (m=0755)
              [/opt/pkg/share/examples/rc.d/xymonclient]

  ===========================================================================

For whatever it's worth, the net/xymon binary package has the proper FILE_NAME:

  # pkg_info -X /opt/pkg/packages/Darwin/x86_64/14.0/All/xymon-4.3.30nb8.tgz  | grep FILE_NAME
  FILE_NAME=xymon-4.3.30nb8.tgz

>How-To-Repeat:

  Build the binary package will show the on-disk filename differes from what pkg_info -X shows.

>Fix: