Re: pkg/57672: pkgsrc guide should mention the iconv const issue

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Date: Sat, 21 Oct 2023 17:18:17 +0200
> From: Thomas Klausner <wiz%NetBSD.org@localhost>
> 
> On Sat, Oct 21, 2023 at 02:25:00PM +0000, campbell+netbsd%mumble.net@localhost wrote:
> > >Number:         57672
> > >Category:       pkg
> > >Synopsis:       pkgsrc guide should mention the iconv const issue
> 
> Starting from NetBSD 10, iconv on NetBSD is the same as everywhere
> else - should we still document this? I think it's too late now :)

A user reported this issue today with wip/newsboat, and netbsd-9 still
has const and probably won't be EOL for another couple of years, so,
yes, I think it is still relevant:

===> Building for newsboat-2.13
c++ -std=c++11 -O2 -ggdb -Iinclude -Istfl -Ifilter -I. -Irss -Werror -Wall -Wextra -Wunreachable-code -DLOCALEDIR=\"/usr/local/share/locale\" -I/home/gnc/pkgsrc/pkg/include -I/home/gnc/pkgsrc/pkg/include/libxml2 -I/home/gnc/pkgsrc/pkg/include -I/home/gnc/pkgsrc/pkg/include -I/home/gnc/pkgsrc/pkg/include/json-c -DHAVE_OPENSSL=1 -O2 -I/usr/include -I/home/gnc/pkgsrc/pkg/include -I/usr/include/krb5 -o src/utils.o -c src/utils.cpp
src/utils.cpp: In static member function 'static std::string newsboat::utils::convert_text(const string&, const string&, const string&)':
src/utils.cpp:363:8: error: invalid conversion from 'const char**' to 'char**' [-fpermissive]
  363 |    cd, &inbufp, &inbytesleft, &outbufp, &outbytesleft);
      |        ^~~~~~~
      |        |
      |        const char**
In file included from /home/gnc/pkgsrc/tree/work/wip/newsboat213/work/.buildlink/include/libxml2/libxml/encoding.h:28,
                 from /home/gnc/pkgsrc/tree/work/wip/newsboat213/work/.buildlink/include/libxml2/libxml/parser.h:810,
                 from include/utils.h:5,
                 from src/utils.cpp:1:
/usr/include/iconv.h:46:23: note:   initializing argument 2 of 'size_t iconv(iconv_t, char**, size_t*, char**, size_t*)'
   46 | size_t iconv(iconv_t, char ** __restrict,
      |                       ^
gmake: *** [Makefile:114: src/utils.o] Error 1