pkg/57901: vim-motif builds, but without motif

[rwhitlock22%gmail.com@localhost]

>Number:         57901
>Category:       pkg
>Synopsis:       vim-motif builds, but without motif
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Feb 03 00:45:00 +0000 2024
>Originator:     Robert Whitlock
>Release:        pkgsrc-2023Q4
>Organization:
>Environment:
NetBSD thinkpad 10.0_RC3 NetBSD 10.0_RC3 (GENERIC_thinkpad) #0: Wed Jan 31 00:00:23 EST 2024  rob@thinkpad:/usr/src/sys/arch/amd64/compile/GENERIC_thinkpad amd64
>Description:
The editors/vim-motif package builds, but its configure.ac was looking for motif in specific locations, none of which included packages under /usr/pkg, predictably, and so gave up on building with motif support. The result is a vim-motif without motif support.
>How-To-Repeat:
cd /usr/pkgsrc/editors/vim-motif
make install
vim -g

and watch it give an error about not being compiled with GUI support.
>Fix:
pkgsrc has configuration settings for the location of motif, so let's use them!

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/editors/vim-motif/Makefile,v
retrieving revision 1.43
diff -u -r1.43 Makefile
--- Makefile	16 Sep 2023 12:43:14 -0000	1.43
+++ Makefile	3 Feb 2024 00:39:14 -0000
@@ -9,7 +9,7 @@
 DEPENDS+=		vim-share-${VIM_VERSION}.${VIM_PATCHLEVEL}{,nb*}:../../editors/vim-share
 CONFLICTS+=		vim-[0-9]* vim-gtk2-[0-9]* vim-gtk3-[0-9]*
 
-CONFIGURE_ARGS+=	--enable-gui=motif
+CONFIGURE_ARGS+=	--enable-gui=motif GUI_INC_LOC=-I${MOTIFBASE:Q}/include GUI_LIB_LOC=-L${MOTIFBASE:Q}/lib
 CONFIGURE_ARGS+=	--with-tlib=${BUILDLINK_LIBNAME.termcap}
 
 CONFIGURE_ENV+=		MOTIFBASE=${MOTIFBASE}