PR/57919 CVS commit: pkgsrc/security/libfido2

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR pkg/57919; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/57919 CVS commit: pkgsrc/security/libfido2
Date: Sat, 10 Feb 2024 03:10:53 +0000

 Module Name:	pkgsrc
 Committed By:	riastradh
 Date:		Sat Feb 10 03:10:53 UTC 2024
 
 Modified Files:
 	pkgsrc/security/libfido2: Makefile distinfo
 	pkgsrc/security/libfido2/patches: patch-CMakeLists.txt
 
 Log Message:
 security/libfido2: Fix NetBSD build, PR pkg/57919.
 
 Patching away -Werror may be reasonable in general, but in this case
 it breaks libfido2's detection of whether ioctl takes int or unsigned
 long on NetBSD -- without -Werror, it wrongly concludes int, and
 proceeds to build a libfido2 that casts every ioctl command to int
 first, which leads to sign extension, which leads to the wrong ioctls
 being passed into the kernel, which leads libfido2 to fail in any
 attempts to open fido devices on NetBSD.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.14 pkgsrc/security/libfido2/Makefile
 cvs rdiff -u -r1.10 -r1.11 pkgsrc/security/libfido2/distinfo
 cvs rdiff -u -r1.1 -r1.2 \
     pkgsrc/security/libfido2/patches/patch-CMakeLists.txt
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.