PR/57919 CVS commit: [pkgsrc-2023Q4] pkgsrc/security/libfido2

["Benny Siegert" <bsiegert%netbsd.org@localhost>]

The following reply was made to PR pkg/57919; it has been noted by GNATS.

From: "Benny Siegert" <bsiegert%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/57919 CVS commit: [pkgsrc-2023Q4] pkgsrc/security/libfido2
Date: Fri, 1 Mar 2024 17:29:55 +0000

 Module Name:	pkgsrc
 Committed By:	bsiegert
 Date:		Fri Mar  1 17:29:55 UTC 2024
 
 Modified Files:
 	pkgsrc/security/libfido2 [pkgsrc-2023Q4]: Makefile distinfo
 	pkgsrc/security/libfido2/patches [pkgsrc-2023Q4]: patch-CMakeLists.txt
 
 Log Message:
 Pullup ticket #6838 - requested by riastradh
 security/libfido2: NetBSD build fix
 
 security/libfido2: Fix NetBSD support (PR 57919) by not patching
 away -Werror in a critical place where the build system relies on
 it to detect whether ioctl argument is int or long.  When the build
 system infers the wrong answer, it builds a libfido2 that doesn't
 work on NetBSD because it sends the wrong (sign-extended) ioctl
 commands to the kernel for USB stuff.
 
 Revisions pulled up:
 - security/libfido2/Makefile                                    1.14
 - security/libfido2/distinfo                                    1.11
 - security/libfido2/patches/patch-CMakeLists.txt                1.2
 
 ---
    Module Name:    pkgsrc
    Committed By:   riastradh
    Date:           Sat Feb 10 03:10:53 UTC 2024
 
    Modified Files:
            pkgsrc/security/libfido2: Makefile distinfo
            pkgsrc/security/libfido2/patches: patch-CMakeLists.txt
 
    Log Message:
    security/libfido2: Fix NetBSD build, PR pkg/57919.
 
    Patching away -Werror may be reasonable in general, but in this case
    it breaks libfido2's detection of whether ioctl takes int or unsigned
    long on NetBSD -- without -Werror, it wrongly concludes int, and
    proceeds to build a libfido2 that casts every ioctl command to int
    first, which leads to sign extension, which leads to the wrong ioctls
    being passed into the kernel, which leads libfido2 to fail in any
    attempts to open fido devices on NetBSD.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.13 -r1.13.2.1 pkgsrc/security/libfido2/Makefile
 cvs rdiff -u -r1.10 -r1.10.2.1 pkgsrc/security/libfido2/distinfo
 cvs rdiff -u -r1.1 -r1.1.4.1 \
     pkgsrc/security/libfido2/patches/patch-CMakeLists.txt
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.