pkg/58473: lang/libunwind 18.0.0+ requires C++17

[phil+netbsd%krylov.eu@localhost]

>Number:         58473
>Category:       pkg
>Synopsis:       lang/libunwind 18.0.0+ requires C++17
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 26 22:25:00 +0000 2024
>Originator:     Phil Krylov
>Release:        pkgsrc-current
>Organization:
krylov.eu
>Environment:
Linux localhost.localdomain 3.10.0-1160.119.1.el7.x86_64 #1 SMP Tue Jun 4 14:43:51 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
>Description:
Under CentOS 7, where GCC 4.8.5 is the default compiler, lang/libunwind build fails with the message that it requires a C++17-compatible compiler. When I raise USE_CXX_FEATURES to c++14, GCC 6.5 is installed and compiles libunwind successfully, but the CMakeLists.txt still say C++17 is required, so I have changed that to c++17 to be on the safe side. Probably c++14 would be enough.
>How-To-Repeat:
bmake -C lang/libunwind bin-install
>Fix:
Index: lang/libunwind/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/libunwind/Makefile,v
retrieving revision 1.37
diff -p -u -r1.37 Makefile
--- lang/libunwind/Makefile	6 Jul 2024 15:45:07 -0000	1.37
+++ lang/libunwind/Makefile	26 Jul 2024 22:13:44 -0000
@@ -18,7 +18,7 @@ EXTRA_DIST+=	${LIBCXX}${EXTRACT_SUFX}
 SITES.${LIBCXX}${EXTRACT_SUFX}=	\
 	${MASTER_SITES:=${GITHUB_PROJECT}/releases/download/${GITHUB_RELEASE}/}
 
-USE_CXX_FEATURES=	c++11
+USE_CXX_FEATURES=	c++17
 USE_LANGUAGES=		c c++
 USE_TOOLS+=		pax
 SSP_SUPPORTED=		no