Re: pkg/58502: devel/patchelf binary package on CentOS 7 should depend on gcc8-libs

[Phil Krylov <phil+netbsd%krylov.eu@localhost>]

The following reply was made to PR pkg/58502; it has been noted by GNATS.

From: Phil Krylov <phil+netbsd%krylov.eu@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/58502: devel/patchelf binary package on CentOS 7 should
 depend on gcc8-libs
Date: Sun, 28 Jul 2024 18:32:51 +0200

 Sorry, here is the corrected patch:
 
 Index: devel/patchelf/Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/devel/patchelf/Makefile,v
 retrieving revision 1.17
 diff -p -u -r1.17 Makefile
 --- devel/patchelf/Makefile	28 Aug 2023 15:09:32 -0000	1.17
 +++ devel/patchelf/Makefile	28 Jul 2024 15:54:50 -0000
 @@ -16,4 +16,18 @@ USE_LANGUAGES=	c c++17
   # std::optional
   GCC_REQD+=	8
 
 +.include "../../mk/bsd.prefs.mk"
 +
 +# This package will link against libstdc++.so from the pkgsrc GCC when 
 the
 +# base OS GCC doesn't meet the minimum requirement. Thus we do this so 
 the
 +# appropriate gcc-libs package will be captured as a dependency, 
 otherwise
 +# binary packages will be broken.
 +# /usr/pkg/bin/patchelf: /lib64/libstdc++.so.6: version 
 `GLIBCXX_3.4.21' not found (required by /usr/pkg/bin/patchelf)
 +.if ${OPSYS} == "Linux"
 +_glibcxx_ver_output_!=	objdump -p ${_OPSYS_LIB_DIRS:=/libstdc++.so.*} 
 2>/dev/null | grep GLIBCXX_3.4.21 || true
 +.  if empty(${_glibcxx_ver_output_})
 +USE_PKGSRC_GCC_RUNTIME=	yes
 +.  endif
 +.endif
 +
   .include "../../mk/bsd.pkg.mk"