pkg/58528: lang/python311 no longer buildlinks gettext-lib, breaking PREFER_PKGSRC=yes builds

[phil+netbsd%krylov.eu@localhost]

>Number:         58528
>Category:       pkg
>Synopsis:       lang/python311 no longer buildlinks gettext-lib, breaking PREFER_PKGSRC=yes builds
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 31 00:25:00 +0000 2024
>Originator:     Phil Krylov
>Release:        pkgsrc-current
>Organization:
krylov.eu
>Environment:
Linux localhost.localdomain 3.10.0-1160.119.1.el7.x86_64 #1 SMP Tue Jun 4 14:43:51 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
>Description:
After these changes:

https://mail-index.netbsd.org/pkgsrc-changes/2024/04/30/msg298646.html (python311)
https://mail-index.netbsd.org/pkgsrc-changes/2024/05/02/msg298887.html (python311)
https://mail-index.netbsd.org/pkgsrc-changes/2024/05/01/msg298754.html (python312)
https://mail-index.netbsd.org/pkgsrc-changes/2024/05/03/msg299059.html (python312)

in lang/python311 and lang/python312, buildlink3.mk does not include ../../devel/gettext-lib/buildlink3.mk anymore.

On the platforms where PREFER_PKGSRC is the default (definitely Linux and probably OpenBSD) it has broken databases/tdb and devel/talloc which are failing in the configure phase: 

Asking python-config for pyembed '--cflags --libs --ldflags --embed' flags        : yes 
Testing pyembed configuration                                                     : Could not build a python embedded interpreter 
Testing pyembed configuration                                                     : Could not build a python embedded interpreter 
The configuration failed
(complete log in /home/pbulk/build/databases/tdb/work/tdb-1.4.10/bin/config.log)

(logs copied from https://us-central.manta.mnx.io/pkgsrc/public/reports/Linux/el7/trunk/x86_64/20240506.1340/tdb-1.4.10/configure.log and many later builds)

config.log says that it cannot find -lintl which is still mentioned in $PREFIX/lib/pkgconfig/python-3.1[12]{,-embed}.pc .

Probably it's not a problem on other platforms. Still, I wonder what was the reasoning behind this change. I can build databases/tdb and devel/talloc successfully if I add `.include "../../devel/gettext-lib/buildlink3.mk"` to their respective Makefiles. But should not it be fixed in lang/python31[12] instead (by reversal of the change)? By the way, python310 still buildlinks gettext-lib and does not seem to have any problems.


>How-To-Repeat:
bmake -C devel/talloc bin-install

or

bmake -C databases/tdb bin-install
>Fix: