pkg/58540: multimedia/gst-plugins1-bad needs -std=gnu++11 with GCC 4.8

[phil+netbsd%krylov.eu@localhost]

>Number:         58540
>Category:       pkg
>Synopsis:       multimedia/gst-plugins1-bad needs -std=gnu++11 with GCC 4.8
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Aug 02 18:20:00 +0000 2024
>Originator:     Phil Krylov
>Release:        pkgsrc-current
>Organization:
krylov.eu
>Environment:
Linux localhost.localdomain 3.10.0-1160.119.1.el7.x86_64 #1 SMP Tue Jun 4 14:43:51 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
>Description:
On a CentOS 7 machine, with GCC 4.8.5, the build fails:

https://us-central.manta.mnx.io/pkgsrc/public/reports/Linux/el7/trunk/x86_64/20240730.2238/gst-plugins1-bad-1.24.5/build.log
>How-To-Repeat:
bmake -C multimedia/gst-plugins1-bad bin-install
>Fix:
Index: multimedia/gst-plugins1-bad/Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/multimedia/gst-plugins1-bad/Makefile.common,v
retrieving revision 1.47
diff -p -u -r1.47 Makefile.common
--- multimedia/gst-plugins1-bad/Makefile.common	5 Mar 2024 14:45:47 -0000	1.47
+++ multimedia/gst-plugins1-bad/Makefile.common	2 Aug 2024 18:12:40 -0000
@@ -26,8 +26,9 @@ DISTNAME=	gst-plugins-bad-${GST_VERSION}
 MASTER_SITES=	https://gstreamer.freedesktop.org/src/gst-plugins-bad/
 EXTRACT_SUFX=	.tar.xz
 
-USE_LANGUAGES=	c c++
-USE_TOOLS+=	pkg-config
+USE_LANGUAGES=		c c++
+USE_CXX_FEATURES=	gnu++11
+USE_TOOLS+=		pkg-config
 
 DISTINFO_FILE=	${.CURDIR}/../../multimedia/gst-plugins1-bad/distinfo
 PATCHDIR=	${.CURDIR}/../../multimedia/gst-plugins1-bad/patches
@@ -35,6 +36,7 @@ PATCHDIR=	${.CURDIR}/../../multimedia/gs
 # "error: 'for' loop initial declarations are only allowed in C99 mode"
 # needs default visibility for fdopen (etc.) on some platforms
 FORCE_C_STD=	gnu99
+FORCE_CXX_STD=	gnu++11
 
 PKGCONFIG_OVERRIDE=		output/pkgconfig/*.pc
 PKGCONFIG_OVERRIDE_STAGE=	pre-install