pkg/58549: lang/nodejs* build fails on CentOS 7

[phil+netbsd%krylov.eu@localhost]

>Number:         58549
>Category:       pkg
>Synopsis:       lang/nodejs* build fails on CentOS 7
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Aug 03 12:55:01 +0000 2024
>Originator:     Phil Krylov
>Release:        pkgsrc-current
>Organization:
krylov.eu
>Environment:
Linux localhost.localdomain 3.10.0-1160.119.1.el7.x86_64 #1 SMP Tue Jun 4 14:43:51 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
>Description:
lang/nodejs* build fails on CentOS, needing newer gas, as follows:

https://us-central.manta.mnx.io/pkgsrc/public/reports/Linux/el7/trunk/x86_64/20240730.2238/nodejs-22.5.1/build.log
https://us-central.manta.mnx.io/pkgsrc/public/reports/Linux/el7/trunk/x86_64/20240730.2238/nodejs-18.20.3/build.log
https://us-central.manta.mnx.io/pkgsrc/public/reports/Linux/el7/trunk/x86_64/20240730.2238/nodejs-20.15.1/build.log

The patch seems to be working well for nodejs20, but may also fix nodejs and nodejs18 builds.
>How-To-Repeat:
bmake -C lang/nodejs20 bin-install
>Fix:
Index: lang/nodejs/Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/lang/nodejs/Makefile.common,v
retrieving revision 1.56
diff -p -u -r1.56 Makefile.common
--- lang/nodejs/Makefile.common	14 Jun 2024 08:58:23 -0000	1.56
+++ lang/nodejs/Makefile.common	3 Aug 2024 12:44:47 -0000
@@ -1,7 +1,5 @@
 # $NetBSD: Makefile.common,v 1.56 2024/06/14 08:58:23 wiz Exp $
 # used by lang/nodejs/Makefile
-# used by lang/nodejs14/Makefile
-# used by lang/nodejs16/Makefile
 # used by lang/nodejs18/Makefile
 # used by lang/nodejs20/Makefile
 
@@ -91,6 +89,16 @@ paxctl:
 	${TOOLS_PLATFORM.paxctl} +m ${DESTDIR}${PREFIX}/bin/node
 .endif
 
+# Newer gas from binutils 2.30+ is required for AVX512VBMI2 instructions.
+.if (${MACHINE_ARCH:Mi?86} || ${MACHINE_ARCH} == "x86_64") && ${OPSYS} == "Linux"
+NODEJS_GAS_VERSION!=      \
+       ( env LC_ALL=C as --version 2>&1 | ${AWK} '/GNU assembler version/ {print $$4}') 2>/dev/null || ${ECHO} 0
+.  if ${NODEJS_GAS_VERSION} != "0" && !(${NODEJS_GAS_VERSION:M2.[3-9][0-9]*} || ${NODEJS_GAS_VERSION:M[3-9]*})
+.include "../../devel/binutils/buildlink3.mk"
+.include "../../devel/binutils/override-as.mk"
+.  endif
+.endif
+
 .if ${OPSYS} != "Darwin"
 .include "../../devel/libexecinfo/buildlink3.mk"
 .endif