Re: pkg/58549: lang/nodejs* build fails on CentOS 7

[Phil Krylov <phil+netbsd%krylov.eu@localhost>]

The following reply was made to PR pkg/58549; it has been noted by GNATS.

From: Phil Krylov <phil+netbsd%krylov.eu@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/58549: lang/nodejs* build fails on CentOS 7
Date: Sat, 03 Aug 2024 17:52:59 +0200

 On 2024-08-03 17:40, Phil Krylov wrote:
 >  Well, I took that test from security/gnutls/Makefile and simplified it 
 > a
 >  little bit. It's working well, I don't see why it's error-prone.
 
 My bad! I should not try to remove ${GREP} from the pipeline, it was 
 responsible for the handling of no-match case. Here is the fixed 
 version:
 
 Index: lang/nodejs/Makefile.common
 ===================================================================
 RCS file: /cvsroot/pkgsrc/lang/nodejs/Makefile.common,v
 retrieving revision 1.56
 diff -p -u -r1.56 Makefile.common
 --- lang/nodejs/Makefile.common	14 Jun 2024 08:58:23 -0000	1.56
 +++ lang/nodejs/Makefile.common	3 Aug 2024 12:44:47 -0000
 @@ -1,7 +1,5 @@
   # $NetBSD: Makefile.common,v 1.56 2024/06/14 08:58:23 wiz Exp $
   # used by lang/nodejs/Makefile
 -# used by lang/nodejs14/Makefile
 -# used by lang/nodejs16/Makefile
   # used by lang/nodejs18/Makefile
   # used by lang/nodejs20/Makefile
 
 @@ -91,6 +89,16 @@ paxctl:
   	${TOOLS_PLATFORM.paxctl} +m ${DESTDIR}${PREFIX}/bin/node
   .endif
 
 +# Newer gas from binutils 2.30+ is required for AVX512VBMI2 
 instructions.
 +.if (${MACHINE_ARCH:Mi?86} || ${MACHINE_ARCH} == "x86_64") && ${OPSYS} 
 == "Linux"
 +NODEJS_GAS_VERSION!=      \
 +       ( env LC_ALL=C as --version 2>&1 | ${GREP} '/GNU assembler 
 version/' || ${AWK} '{print $$4}') 2>/dev/null || ${ECHO} 0
 +.  if ${NODEJS_GAS_VERSION} != "0" && 
 !(${NODEJS_GAS_VERSION:M2.[3-9][0-9]*} || ${NODEJS_GAS_VERSION:M[3-9]*})
 +.include "../../devel/binutils/buildlink3.mk"
 +.include "../../devel/binutils/override-as.mk"
 +.  endif
 +.endif
 +
   .if ${OPSYS} != "Darwin"
   .include "../../devel/libexecinfo/buildlink3.mk"
   .endif