pkg/58597: AIX bootstap on pkgsrc

[vchaves%ymail.com@localhost]

>Number:         58597
>Category:       pkg
>Synopsis:       AIX bootstap on pkgsrc
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 14 15:55:00 +0000 2024
>Originator:     Vicente Chaves de Melo
>Release:        pkgsrc-current
>Organization:
>Environment:
AIX plsasmbtest 2 7 00F9EC384C00
>Description:
bootstrap fail on AIX

You can now run

        sh ./make-bootstrap.sh

to produce a fully functional bmake.

===> running: (cd /home/vchaves/workdir/bmake && /usr/bin/sh make-bootstrap.sh)
/opt/freeware/bin/gcc -c -g -O2 -I. -I/home/vchaves/workdir/bmake -DHAVE_CONFIG_H -DMAKE_NATIVE -DUSE_META -DBMAKE_PATH_MAX=1024 -DMAKE_VERSION="20240711" -DMACHINE="00f9ec384c00" -DMACHINE_ARCH="powerpc" -DMAKE_OS="" -D_PATH_DEFSYSPATH="/home/vchaves/workdir/share/mk" -o main.o /home/vchaves/workdir/bmake/main.c
/opt/freeware/bin/gcc -c -g -O2 -I. -I/home/vchaves/workdir/bmake -DHAVE_CONFIG_H -DMAKE_NATIVE -DUSE_META -DBMAKE_PATH_MAX=1024 -o arch.o /home/vchaves/workdir/bmake/arch.c
/home/vchaves/workdir/bmake/arch.c: In function 'ArchStatMember':
/home/vchaves/workdir/bmake/arch.c:419:37: error: 'struct ar_hdr' has no member named 'ar_name'; did you mean '_ar_name'?
  419 | #define AR_MAX_NAME_LEN (sizeof arh.ar_name - 1)
      |                                     ^~~~~~~
/home/vchaves/workdir/bmake/arch.c:447:14: note: in expansion of macro 'AR_MAX_NAME_LEN'
  447 |    char copy[AR_MAX_NAME_LEN + 1];
      |              ^~~~~~~~~~~~~~~
/home/vchaves/workdir/bmake/arch.c:419:37: error: 'struct ar_hdr' has no member named 'ar_name'; did you mean '_ar_name'?
  419 | #define AR_MAX_NAME_LEN (sizeof arh.ar_name - 1)
      |                                     ^~~~~~~
/home/vchaves/workdir/bmake/arch.c:450:14: note: in expansion of macro 'AR_MAX_NAME_LEN'
  450 |    if (len > AR_MAX_NAME_LEN) {
      |              ^~~~~~~~~~~~~~~
/home/vchaves/workdir/bmake/arch.c:419:37: error: 'struct ar_hdr' has no member named 'ar_name'; did you mean '_ar_name'?
  419 | #define AR_MAX_NAME_LEN (sizeof arh.ar_name - 1)
      |                                     ^~~~~~~
/home/vchaves/workdir/bmake/arch.c:488:10: note: in expansion of macro 'AR_MAX_NAME_LEN'
  488 |  memName[AR_MAX_NAME_LEN] = '\0';
      |          ^~~~~~~~~~~~~~~
/home/vchaves/workdir/bmake/arch.c:419:37: error: 'struct ar_hdr' has no member named 'ar_name'; did you mean '_ar_name'?
  419 | #define AR_MAX_NAME_LEN (sizeof arh.ar_name - 1)
      |                                     ^~~~~~~
/home/vchaves/workdir/bmake/arch.c:500:23: note: in expansion of macro 'AR_MAX_NAME_LEN'
  500 |   nameend = memName + AR_MAX_NAME_LEN;
      |                       ^~~~~~~~~~~~~~~
===> exited with status 1
aborted.

>How-To-Repeat:
try to bootstrap pkgsrc-current on AIX 7.2
>Fix:
cvs diff
Index: arch.c
===================================================================
RCS file: /cvsroot/pkgsrc/devel/bmake/files/arch.c,v
retrieving revision 1.10
diff -u -r1.10 arch.c
--- arch.c      15 Jul 2024 09:10:06 -0000      1.10
+++ arch.c      14 Aug 2024 15:48:23 -0000
@@ -416,7 +416,7 @@
 static struct ar_hdr *
 ArchStatMember(const char *archive, const char *member, bool addToCache)
 {
-#define AR_MAX_NAME_LEN (sizeof arh.ar_name - 1)
+#define AR_MAX_NAME_LEN (sizeof arh.AR_NAME - 1)
        FILE *arch;
        size_t size;            /* Size of archive member */
        char magic[SARMAG];