Re: pkg/57145 (gmake: *** INTERNAL: readdir: Operation not supported. Stop.)

[mrg%NetBSD.org@localhost]

Synopsis: gmake: *** INTERNAL: readdir: Operation not supported.  Stop.

State-Changed-From-To: feedback->open
State-Changed-By: mrg%NetBSD.org@localhost
State-Changed-When: Fri, 30 Aug 2024 21:52:34 +0000
State-Changed-Why:
my fix didn't do anything, but i've come to the conclusion that Andrew
is right about lseek() being the problem.

we store lseek() into dirp->dd_seek for later usage, and in the case
that it returns -1 and sets errno (this PR shows EOPNOTSUPP but most
instances i've and others have seen is EINVAL - mine happens on pure
FFS obj, not in a chroot.)  we don't check this value in readdir()
so if it happens, it would explain how this issue happens.  the other
case is that if getdents() returns 0 or negative and errno is set when
returning NULL.