re: pkg/57145: gmake: *** INTERNAL: readdir: Operation not supported. Stop.

[gnats-admin%netbsd.org@localhost]

The following reply was made to PR pkg/57145; it has been noted by GNATS.

From: matthew green <mrg%eterna23.net@localhost>
To: Taylor R Campbell <riastradh%NetBSD.org@localhost>
Cc: Andrew Cagney <andrew.cagney%gmail.com@localhost>, gnats-bugs%NetBSD.org@localhost,
    netbsd-bugs%NetBSD.org@localhost
Subject: re: pkg/57145: gmake: *** INTERNAL: readdir: Operation not supported. Stop.
Date: Mon, 02 Sep 2024 04:47:40 +1000

 > > this is a gmake bug.  it checks errno after readdir() but readdir() is
 > > not expected to set/clear errno for 'end of dir' condition, and thus
 > > converts some prior random error into a readdir error.
 >
 > Not a gmake bug.  readdir is required to preserve errno in the
 
 yes - the call in gmake always sets errno = 0 before calling
 readdir, but it's via a macro and i missed this.
 
 i *thought* the bug was not setting errno = 0 before.
 
 > Can you share your reproducer for this?  Maybe we can adapt it to an
 > atf test.
 
 "use pkgsrc, see this failure every few weeks or so".
 
 
 .mrg.