pkg/58867: sysutils/libnotify build error

[rwhitlock22%gmail.com@localhost]

>Number:         58867
>Category:       pkg
>Synopsis:       sysutils/libnotify build error
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 01 16:45:00 +0000 2024
>Originator:     Robert Whitlock
>Release:        pkgsrc current, Sat Nov 30, 2024
>Organization:
>Environment:
NetBSD current 10.99.12, Sat Nov 9, 2024
>Description:
Build fails looking for gi-docgen, which seems to be the devel/py-gi-docgen package. This dependency is needed to build the documentation when using the doc option. Output below:

=> Bootstrap dependency digest>=20211023: found digest-20220214
===> Skipping vulnerability checks.
WARNING: No /usr/pkg/pkgdb/pkg-vulnerabilities file found.
WARNING: To fix run: `/usr/sbin/pkg_admin -K /usr/pkg/pkgdb fetch-pkg-vulnerabilities'.
===> Configuring for libnotify-0.8.3nb2
=> Generating pkg-config files for builtin xz package.
The Meson build system
Version: 1.6.0
Source dir: /usr/pkgsrc/sysutils/libnotify/work/libnotify-0.8.3
Build dir: /usr/pkgsrc/sysutils/libnotify/work/libnotify-0.8.3/output
Build type: native build
Project name: libnotify
Project version: 0.8.3
C compiler for the host machine: gcc (gcc 12.4.0 "gcc (nb1 20240630) 12.4.0")
C linker for the host machine: gcc ld.bfd 2.42
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: YES (/usr/pkgsrc/sysutils/libnotify/work/.tools/bin/pkg-config) 2.3.0
Run-time dependency gdk-pixbuf-2.0 found: YES 2.42.12
Run-time dependency glib-2.0 found: YES 2.82.2
Run-time dependency gio-2.0 found: YES 2.82.2
WARNING: Found CMake '/usr/pkgsrc/sysutils/libnotify/work/.tools/bin/false' but couldn't run it
Found CMake: NO
Run-time dependency gtk+-3.0 found: NO (tried pkgconfig and cmake)
Configuring config.h using configuration
Program xsltproc found: YES (/usr/pkg/bin/xsltproc)
Configuring notify-features.h using configuration
Dependency glib-2.0 found: YES 2.82.2 (cached)
Program /usr/pkg/bin/glib-mkenums found: YES (/usr/pkg/bin/glib-mkenums)
Dependency glib-2.0 found: YES 2.82.2 (cached)
Program /usr/pkg/bin/glib-mkenums found: YES (/usr/pkg/bin/glib-mkenums)
Dependency glib-2.0 found: YES 2.82.2 (cached)
Program /usr/pkg/bin/glib-genmarshal found: YES (/usr/pkg/bin/glib-genmarshal)
Compiler for C supports link arguments -Wl,--version-script,/usr/pkgsrc/sysutils/libnotify/work/libnotify-0.8.3/libnotify/libnotify.map: YES 
Program g-ir-scanner found: YES (/usr/pkg/bin/g-ir-scanner)
Run-time dependency gobject-introspection-1.0 found: YES 1.80.1
Dependency gobject-introspection-1.0 found: YES 1.80.1 (cached)
Program /usr/pkg/bin/g-ir-scanner found: YES (/usr/pkg/bin/g-ir-scanner)
Dependency gobject-introspection-1.0 found: YES 1.80.1 (cached)
Program /usr/pkg/bin/g-ir-compiler found: YES (/usr/pkg/bin/g-ir-compiler)
Program xmlto found: YES (/usr/pkg/bin/xmlto)
Configuring libnotify.toml using configuration
WARNING: Found CMake '/usr/pkgsrc/sysutils/libnotify/work/.tools/bin/false' but couldn't run it
Found CMake: NO
Build-time dependency gi-docgen found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency gi-docgen

docs/reference/meson.build:13:0: ERROR: Subproject exists but has no meson.build file.

A full log can be found at /usr/pkgsrc/sysutils/libnotify/work/libnotify-0.8.3/output/meson-logs/meson-log.txt
*** Error code 1

Stop.
make[1]: stopped making "install" in /usr/pkgsrc/sysutils/libnotify
*** Error code 1

Stop.
make: stopped making "install" in /usr/pkgsrc/sysutils/libnotify

>How-To-Repeat:
enable doc option for libnotify
cd sysutils/libnotify
make install
>Fix:
I tried adding a dependency for py-gi-docgen and fixing a bit of the python tool dependency, but meson still doesn't find gi-docgen and I'm not sure why. Here is what I have done:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/libnotify/Makefile,v
retrieving revision 1.83
diff -u -r1.83 Makefile
--- Makefile    17 Nov 2024 07:16:41 -0000      1.83
+++ Makefile    30 Nov 2024 17:36:45 -0000
@@ -28,7 +28,7 @@
 BUILDLINK_TRANSFORM.SunOS+=    rm:-Wl,--version-script
 BUILDLINK_TRANSFORM.SunOS+=    rm:-Wl,${WRKSRC}/libnotify/libnotify.map
 
-PYTHON_FOR_BUILD_ONLY= tool
+#PYTHON_FOR_BUILD_ONLY=        tool
 
 .include "options.mk"
 
Index: options.mk
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/libnotify/options.mk,v
retrieving revision 1.9
diff -u -r1.9 options.mk
--- options.mk  14 Feb 2023 14:03:53 -0000      1.9
+++ options.mk  30 Nov 2024 17:36:45 -0000
@@ -9,6 +9,8 @@
 
 .if !empty(PKG_OPTIONS:Mdoc)
 TOOL_DEPENDS+=         gtk-doc-[0-9]*:../../textproc/gtk-doc
+TOOL_DEPENDS+=         ${PYPKGPREFIX}-gi-docgen-[0-9]*:../../devel/py-gi-docgen
+.include "../../lang/python/tool.mk"
 TOOL_DEPENDS+=         xmlto-[0-9]*:../../textproc/xmlto
 PLIST.doc=             yes
 MESON_ARGS+=           -Ddocbook_docs=enabled