pkg/58868: pkgsrc bootstrap fails on Cygwin due to libarchive bug

[earldridgejazzedpineda%gmail.com@localhost]

>Number:         58868
>Category:       pkg
>Synopsis:       pkgsrc bootstrap fails on Cygwin due to libarchive bug
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 03 06:50:00 +0000 2024
>Originator:     Earldridge Jazzed Pineda
>Release:        pkgsrc current
>Organization:
>Environment:
CYGWIN_NT-10.0-26120 LAPTOP-NOC97PU3 3.5.4-1.x86_64 2024-08-25 16:52 UTC x86_64 Cygwin
>Description:
Running the pkgsrc bootstrap script on Cygwin fails during the compilation of libarchive. The first five errors produced by GCC are:
/usr/include/w32api/bcrypt.h:27:11: error: unknown type name 'LONG'
   27 |   typedef LONG NTSTATUS,*PNTSTATUS;
      |           ^~~~
/usr/include/w32api/bcrypt.h:174:5: error: unknown type name 'ULONG'
  174 |     ULONG dwMinLength;
      |     ^~~~~
/usr/include/w32api/bcrypt.h:175:5: error: unknown type name 'ULONG'
  175 |     ULONG dwMaxLength;
      |     ^~~~~
/usr/include/w32api/bcrypt.h:176:5: error: unknown type name 'ULONG'
  176 |     ULONG dwIncrement;
      |     ^~~~~
/usr/include/w32api/bcrypt.h:182:5: error: unknown type name 'ULONG'
  182 |     ULONG cbOID;
      |     ^~~~~
>How-To-Repeat:
1. Download the Cygwin setup program
2. Run the setup program to install Cygwin
3. Run the setup program again and install the following packages: gcc-core gcc-fortran gcc-g++
4. Download pkgsrc as a tar file or by using CVS or Git and extract its contents to ~/pkgsrc
5. In the pkgsrc directory, run "bootstrap/bootstrap --unprivileged"
>Fix:
Apply the patch file at https://github.com/libarchive/libarchive/commit/40ff837717b89e9a5d2c735758f503d124d17b72.patch to the libarchive source code at archivers/libarchive/files.