Re: pkg/58961: 'make print-PLIST' emits 'No such file or directory' when directories contain spaces

[Taylor R Campbell <campbell%mumble.net@localhost>]

> Date: Tue, 07 Jan 2025 03:11:13 -0500
> From: iris000%duck.com@localhost
> 
> Taylor R Campbell wrote:
> > Can you please try the attached patch and see if it helps?
> 
> > Correction -- updated patch attached, to work around the quirk of
> > shells where x=$(...) strips the trailing newlines of the command
> > output.
> 
> I can confirm with 'pr58961-printplistifs-v2.patch' that 'make
> print-PLIST' no longer shows 'No such file or directory' when
> encountering directory names with spaces, and that @pkgdir entries are
> now being generated for empty directories when their paths contain a
> space (and @pkgdir entries without spaces are hopefully unchanged).

Great, thanks!

> (It seems biology/fastqc upstream has shipped with these empty
> directories since v0.11.6, just that @pkgdir entries could not be
> generated for them until now.)
> [...]
> >  share/doc/fastqc/Help/1 Introduction/.svn/entries
> >  share/doc/fastqc/Help/1 Introduction/.svn/text-base/1.1 What is FastQC.html.svn-base
> [...]
> > +@pkgdir share/doc/fastqc/Help/3 Analysis Modules/.svn/tmp/props
> > +@pkgdir share/doc/fastqc/Help/3 Analysis Modules/.svn/props
> > +@pkgdir share/doc/fastqc/Help/2 Basic Operations/.svn/tmp/props
> > +@pkgdir share/doc/fastqc/Help/2 Basic Operations/.svn/props
> > +@pkgdir share/doc/fastqc/Help/1 Introduction/.svn/tmp/props
> > +@pkgdir share/doc/fastqc/Help/1 Introduction/.svn/props

Grody!  I don't think any of these .svn directories should be there.
Maybe we should have a check for directories named .svn, .git, .hg,
_darcs, &c., in the destdir.  This package should maybe delete them in
the do-install target before copying stuff to the destdir.