pkg/58986: devel/py-pysvn hard-codes /usr/pkg

[campbell+netbsd%mumble.net@localhost]

>Number:         58986
>Category:       pkg
>Synopsis:       devel/py-pysvn hard-codes /usr/pkg
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 12 08:40:00 +0000 2025
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The PyBSD Subversion
>Environment:
>Description:
===> Configuring for py310-pysvn-1.9.22nb3  
=> Substituting "path" in setup_configure.py                 
Info: Configure for python 3.10.16 in exec_prefix /pkg/2024Q4
Info: Using C compiler cc   
Info: Using C++ compiler g++
Info: Checking for PyCXX include in ../Import/pycxx-7.1.9/CXX/Version.hxx
Info: Found  PyCXX include in /tmp/pkgbuild/2024Q4/devel/py-pysvn/work/pysvn-1.9.22/Import/pycxx-7.1.9
Info: Checking for PyCXX Source in /tmp/pkgbuild/2024Q4/devel/py-pysvn/work/pysvn-1.9.22/Import/pycxx-7.1.9/Src/cxxsupport.cxx
Info: Found   PyCXX Source in /tmp/pkgbuild/2024Q4/devel/py-pysvn/work/pysvn-1.9.22/Import/pycxx-7.1.9/Src
Info: Checking for SVN include in /usr/include/subversion-1/svn_client.h      
Info: Checking for SVN include in /usr/local/include/subversion-1/svn_client.h
Info: Checking for SVN include in /usr/pkg/include/subversion-1/svn_client.h
Info: Checking for SVN include in /usr/include/subversion-1/svn_client.h      
Info: Checking for SVN include in /usr/local/include/subversion-1/svn_client.h
Info: Checking for SVN include in /usr/pkg/include/subversion-1/svn_client.h
Error: Cannot find SVN include svn_client.h - use --svn-inc-dir

$ grep -r -n /usr/pkg .
./Source/setup_configure.py:1094:                            '/usr/pkg/lib',                         # netbsd
./Source/setup_configure.py:1198:                        '/usr/pkg/include/subversion-1',        # netbsd
./Source/setup_configure.py:1203:                        '/usr/pkg/bin',                         # netbsd
./Source/setup_configure.py:1210:                        '/usr/pkg/lib',                         # netbsd
./Source/setup_configure.py:1217:                        '/usr/pkg/include/apr-1',               # netbsd
./Source/setup_configure.py:1230:                        '/usr/pkg/lib',                         # netbsd

>How-To-Repeat:
1. bootstrap pkgsrc into a prefix other than /usr/pkg, e.g. /opt/pkg or ~/pkg
2. build devel/py-pysvn
>Fix:
1. patch to use @LOCALBASE@/include, @LOCALBASE@/lib, &c.
2. SUBST for @LOCALBASE@