pkg/58989: audio/qmmp: missing PLIST conditionals for dbus

[campbell+netbsd%mumble.net@localhost]

>Number:         58989
>Category:       pkg
>Synopsis:       audio/qmmp: missing PLIST conditionals for dbus
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 12 15:25:00 +0000 2025
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The NetQMMP Dbustitution
>Environment:
>Description:
Various components of audio/qmmp are conditional on whether qt was built with dbus.  Excerpt of qmmp-1.6.5/src/plugins/General/CMakeLists.txt:

IF(USE_MPRIS AND Qt5DBus_FOUND)
add_subdirectory(mpris)
ENDIF(USE_MPRIS AND Qt5DBus_FOUND)
...
IF(USE_KDENOTIFY AND Qt5DBus_FOUND)
add_subdirectory(kdenotify)
ENDIF(USE_KDENOTIFY AND Qt5DBus_FOUND)

Building qt with -dbus leads to the following build failure:

  => Checking file-check results for qmmp-1.6.5nb12
  ERROR: ************************************************************
  ERROR: The following files are in the PLIST but not in /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4:
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libgnomehotkey.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libkdenotify.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libmpris.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libsleepinhibitor.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libudisks.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/share/qmmp-1/images/app_icon.png
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/share/qmmp-1/images/empty_cover.png

>How-To-Repeat:
1. set PKG_DEFAULT_OPTIONS+=-dbus
2. build audio/qmmp
>Fix:
Yes, please!

(May want to add some of this to PRINT_PLIST_AWK to help future maintainers too.)