Re: pkg/59028: qt5-qtwebkit doesn't build

["Taylor R Campbell via gnats" <gnats-admin%NetBSD.org@localhost>]

The following reply was made to PR pkg/59028; it has been noted by GNATS.

From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost, pkgsrc-bugs%NetBSD.org@localhost
Cc: nia%NetBSD.org@localhost, wiz%NetBSD.org@localhost
Subject: Re: pkg/59028: qt5-qtwebkit doesn't build
Date: Sat, 25 Jan 2025 13:59:02 +0000

 > Date: Sat, 25 Jan 2025 12:05:19 +0000
 > From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
 >=20
 > > /scratch/x11/qt5-qtwebkit/work/.cwrapper/bin/c++ [...] -std=3Dc++11 [..=
 .]
 > > [...]
 > > /usr/pkg/include/unicode/uset.h:1655:10: error: 'u16string_view' in nam=
 espace 'std' does not name a type; did you mean 'u16string'?
 > >  1655 |     std::u16string_view operator*() const {
 > >       |          ^~~~~~~~~~~~~~
 > >       |          u16string
 >=20
 > This looks like C++17 <string_view> artefacts.  -std=3Dc++11 probably
 > won't cut it here.  textproc/icu/buildlink3.mk probably needs to
 > require all downstream packages to use C++17.
 
 Perhaps less invasive: icu header files seem to have a
 U_HIDE_DRAFT_API macro; defining it suppresses a lot of this.
 
 Not all of this -- unicode/uset.h still uses <string_view> in places
 -- but it might be an upstream bug that any parts are missed, so maybe
 we could patch those parts of icu instead of forcing C++17.