Subject: use of ls in mk/bulk/post-build
To: None <tv@netbsd.org>
From: Jan Schaumann <jschauma@netmeister.org>
List: pkgsrc-bulk
Date: 04/11/2005 16:34:06
--oC1+HKm2/end4ao3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

In rev 1.49 of  pkgsrc/mk/bulk/post-build, you committed

-chdir($USR_PKGSRC);
-system("find . -name $BROKENFILE -print -o -name $BROKENWRKLOG -print | $G=
TAR -T - -plcf - | (cd $FTP; $GTAR -plxf -)");
+chdir($vars{USR_PKGSRC});
+my_system("/bin/ls -1 $vars{BROKENFILE} $vars{BROKENWRKLOG} */*/$vars{BROK=
ENFILE} */*/$vars{BROKENWRKLOG} 2>/dev/null | $vars{GTAR} -T - -plcf - | (c=
d $vars{FTP}; $vars{GTAR} -plxf -)");


On some systems, this now leads to too many arguments to ls(1),
subsequently producing an empty bulk-log.  What was wrong with using
find(1)?

-Jan=20

--=20
Wenn ich tot bin, mir soll mal Einer mit Auferstehung oder so
kommen, ich hau ihm eine rein! (Anonym)

--oC1+HKm2/end4ao3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (NetBSD)

iD8DBQFCWt8+fFtkr68iakwRAmu0AJ0fnxX6f8BoOBgYRMdYfD4/ToxOUACglT7L
4upmd1bKYa1r+Mtfw/rJla8=
=FoO7
-----END PGP SIGNATURE-----

--oC1+HKm2/end4ao3--