[pkgsrc/trunk]: pkgsrc/fonts/harfbuzz Fix _POSIX_C_SOURCE abuse for at least ...

[abs <abs%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/743740ec7651
branches:  trunk
changeset: 324789:743740ec7651
user:      abs <abs%pkgsrc.org@localhost>
date:      Mon Oct 29 13:55:14 2018 +0000

description:
Fix _POSIX_C_SOURCE abuse for at least NetBSD to fix gcc6/7/8 build

Also add USE_GCC_RUNTIME

Bump PKGREVISION

diffstat:

 fonts/harfbuzz/Makefile                     |   4 +++-
 fonts/harfbuzz/distinfo                     |   3 ++-
 fonts/harfbuzz/patches/patch-src_hb-blob.cc |  27 +++++++++++++++++++++++++++
 3 files changed, 32 insertions(+), 2 deletions(-)

diffs (63 lines):

diff -r cb354f4e0ff0 -r 743740ec7651 fonts/harfbuzz/Makefile
--- a/fonts/harfbuzz/Makefile   Mon Oct 29 13:27:25 2018 +0000
+++ b/fonts/harfbuzz/Makefile   Mon Oct 29 13:55:14 2018 +0000
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.98 2018/08/19 17:24:55 wiz Exp $
+# $NetBSD: Makefile,v 1.99 2018/10/29 13:55:14 abs Exp $
 
 DISTNAME=      harfbuzz-1.8.8
+PKGREVISION=   1
 CATEGORIES=    fonts
 MASTER_SITES=  http://www.freedesktop.org/software/harfbuzz/release/
 EXTRACT_SUFX=  .tar.bz2
@@ -16,6 +17,7 @@
 GNU_CONFIGURE=         yes
 CONFIGURE_ARGS+=       --with-cairo=no
 CONFIGURE_ARGS+=       --with-graphite2=no
+USE_GCC_RUNTIME=       yes
 
 PKGCONFIG_OVERRIDE+=   src/harfbuzz.pc.in
 PKGCONFIG_OVERRIDE+=   src/harfbuzz-icu.pc.in
diff -r cb354f4e0ff0 -r 743740ec7651 fonts/harfbuzz/distinfo
--- a/fonts/harfbuzz/distinfo   Mon Oct 29 13:27:25 2018 +0000
+++ b/fonts/harfbuzz/distinfo   Mon Oct 29 13:55:14 2018 +0000
@@ -1,6 +1,7 @@
-$NetBSD: distinfo,v 1.77 2018/08/19 17:24:55 wiz Exp $
+$NetBSD: distinfo,v 1.78 2018/10/29 13:55:14 abs Exp $
 
 SHA1 (harfbuzz-1.8.8.tar.bz2) = be496408b2bb3dc794891e8b0e977cd75f02d71d
 RMD160 (harfbuzz-1.8.8.tar.bz2) = 3b4a94557770bc0aeb7a0a1d7fb3ac2c92830fc5
 SHA512 (harfbuzz-1.8.8.tar.bz2) = eb96cd710571a96473b20bc9a01dadf2a3c11224497e52c63368e8edec64a8eb7085dd847c78111b798a1e8a6a950f0a04c930209822aabf13cf86d7a53b1f79
 Size (harfbuzz-1.8.8.tar.bz2) = 3862626 bytes
+SHA1 (patch-src_hb-blob.cc) = 9f2858357d2a1fc8bf58c98b02041640557f6593
diff -r cb354f4e0ff0 -r 743740ec7651 fonts/harfbuzz/patches/patch-src_hb-blob.cc
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/fonts/harfbuzz/patches/patch-src_hb-blob.cc       Mon Oct 29 13:55:14 2018 +0000
@@ -0,0 +1,27 @@
+$NetBSD: patch-src_hb-blob.cc,v 1.1 2018/10/29 13:55:14 abs Exp $
+
+Quoting the URL given in the source:
+
+  The POSIX standard states that a strictly conforming application
+  "for the C programming language, shall define _POSIX_C_SOURCE to
+  be 200112L before any header is included."
+
+Asserting this for only one file out of an application is not defined,
+and the standards also explicitly do not apply to c++.
+
+Its quite possible that some operating systems need _POSIX_C_SOURCE
+set to build this file, but its not a general solution, and lets
+not do it on NetBSD where is interacts badly with at least gcc-6.4
+7.3 and 8.2 on NetBSD-8/amd64
+
+--- src/hb-blob.cc.orig        2018-06-05 22:13:36.000000000 +0000
++++ src/hb-blob.cc
+@@ -26,7 +26,7 @@
+  */
+ 
+ /* http://www.oracle.com/technetwork/articles/servers-storage-dev/standardheaderfiles-453865.html */
+-#ifndef _POSIX_C_SOURCE
++#if !defined(_POSIX_C_SOURCE) && !defined(__NetBSD__)
+ #define _POSIX_C_SOURCE 200809L
+ #endif
+