[pkgsrc/trunk]: pkgsrc/textproc/icu Apply ICU-20208 uspoof.cpp function check...

[abs <abs%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/147cf34fb85a
branches:  trunk
changeset: 326641:147cf34fb85a
user:      abs <abs%pkgsrc.org@localhost>
date:      Tue Dec 11 10:15:55 2018 +0000

description:
Apply ICU-20208 uspoof.cpp function checkImpl should be static from
https://github.com/unicode-org/icu/commit/8baff8f03e07d8e02304d0c888d0bb21ad2eeb01

This should fix the firefox build with this version of icu

Bump PKGREVISION

diffstat:

 textproc/icu/Makefile                               |   3 ++-
 textproc/icu/distinfo                               |   4 +++-
 textproc/icu/patches/patch-common_unicode_urename.h |  15 +++++++++++++++
 textproc/icu/patches/patch-i18n_uspoof.cpp          |  16 ++++++++++++++++
 4 files changed, 36 insertions(+), 2 deletions(-)

diffs (77 lines):

diff -r 238052ef2b46 -r 147cf34fb85a textproc/icu/Makefile
--- a/textproc/icu/Makefile     Tue Dec 11 09:51:59 2018 +0000
+++ b/textproc/icu/Makefile     Tue Dec 11 10:15:55 2018 +0000
@@ -1,7 +1,8 @@
-# $NetBSD: Makefile,v 1.117 2018/12/09 18:28:16 adam Exp $
+# $NetBSD: Makefile,v 1.118 2018/12/11 10:15:55 abs Exp $
 
 DISTNAME=      icu4c-63_1-src
 PKGNAME=       ${DISTNAME:S/4c//:S/-src//:S/_/./g}
+PKGREVISION=   1
 CATEGORIES=    textproc
 MASTER_SITES=  http://download.icu-project.org/files/icu4c/${PKGVERSION_NOREV}/
 EXTRACT_SUFX=  .tgz
diff -r 238052ef2b46 -r 147cf34fb85a textproc/icu/distinfo
--- a/textproc/icu/distinfo     Tue Dec 11 09:51:59 2018 +0000
+++ b/textproc/icu/distinfo     Tue Dec 11 10:15:55 2018 +0000
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.79 2018/12/09 18:28:16 adam Exp $
+$NetBSD: distinfo,v 1.80 2018/12/11 10:15:55 abs Exp $
 
 SHA1 (icu4c-63_1-src.tgz) = ad523232f19af1c698c6489f8e15f7e9824f1662
 RMD160 (icu4c-63_1-src.tgz) = 5c895a6e2b135978df59e135ed772747aec0065f
@@ -10,6 +10,7 @@
 SHA1 (patch-common_putilimp.h) = a68faa97c2bffeecaca1586e26f5bbe48e71b262
 SHA1 (patch-common_umutex.h) = 096d3e15ef7b84533456af4570ed70747a4ef70c
 SHA1 (patch-common_unicode_platform.h) = 8b7b8bcf6f5185225a1ca516ac212a495f7b47e8
+SHA1 (patch-common_unicode_urename.h) = bc27b21c9a041a16ed1dd077e5c5af7e4cee4cf3
 SHA1 (patch-common_uposixdefs.h) = 4739ca7d4662335adcb322cd0943770651d548ce
 SHA1 (patch-config_Makefile.inc.in) = e7cee161315321d2580074054d87714b55319886
 SHA1 (patch-config_icu-config-bottom) = 168b89ee9180d4ae545125866ee91eb004010501
@@ -19,6 +20,7 @@
 SHA1 (patch-configure) = fdeae51f4390779dfd8df8471196e322cbb9ea3d
 SHA1 (patch-configure.ac) = b0291cf02351cbad9b0c7340baea9eb81cabb158
 SHA1 (patch-i18n_double-conversion-utils.h) = 773e93ed9baffa241d5af61bd631d2d7c4a867f8
+SHA1 (patch-i18n_uspoof.cpp) = b7d1757912a6da39c080b1453f4730cbb9b5fd65
 SHA1 (patch-icudefs.mk.in) = c2a9469bf896b5f0702d5795c3b1c2b394893663
 SHA1 (patch-runConfigureICU) = 3cd60613104fa4f1b81529795e75d5cf7f477b64
 SHA1 (patch-tools-toolutil-pkg_genc.cpp) = 3cbcf3387d6a39315b26a3e2a2ffb715507e9110
diff -r 238052ef2b46 -r 147cf34fb85a textproc/icu/patches/patch-common_unicode_urename.h
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/textproc/icu/patches/patch-common_unicode_urename.h       Tue Dec 11 10:15:55 2018 +0000
@@ -0,0 +1,15 @@
+$NetBSD: patch-common_unicode_urename.h,v 1.1 2018/12/11 10:15:56 abs Exp $
+
+ICU-20208 uspoof.cpp function checkImpl should be static
+https://github.com/unicode-org/icu/commit/8baff8f03e07d8e02304d0c888d0bb21ad2eeb01
+
+--- common/unicode/urename.h.orig      2018-10-15 18:02:37.000000000 +0000
++++ common/unicode/urename.h
+@@ -110,7 +110,6 @@
+ #define _UTF7Data U_ICU_ENTRY_POINT_RENAME(_UTF7Data)
+ #define _UTF8Data U_ICU_ENTRY_POINT_RENAME(_UTF8Data)
+ #define allowedHourFormatsCleanup U_ICU_ENTRY_POINT_RENAME(allowedHourFormatsCleanup)
+-#define checkImpl U_ICU_ENTRY_POINT_RENAME(checkImpl)
+ #define cmemory_cleanup U_ICU_ENTRY_POINT_RENAME(cmemory_cleanup)
+ #define dayPeriodRulesCleanup U_ICU_ENTRY_POINT_RENAME(dayPeriodRulesCleanup)
+ #define deleteAllowedHourFormats U_ICU_ENTRY_POINT_RENAME(deleteAllowedHourFormats)
diff -r 238052ef2b46 -r 147cf34fb85a textproc/icu/patches/patch-i18n_uspoof.cpp
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/textproc/icu/patches/patch-i18n_uspoof.cpp        Tue Dec 11 10:15:55 2018 +0000
@@ -0,0 +1,16 @@
+$NetBSD: patch-i18n_uspoof.cpp,v 1.1 2018/12/11 10:15:56 abs Exp $
+
+ICU-20208 uspoof.cpp function checkImpl should be static
+https://github.com/unicode-org/icu/commit/8baff8f03e07d8e02304d0c888d0bb21ad2eeb01
+
+--- i18n/uspoof.cpp.orig       2018-09-29 00:34:42.000000000 +0000
++++ i18n/uspoof.cpp
+@@ -547,7 +547,7 @@ uspoof_checkUnicodeString(const USpoofCh
+     return uspoof_check2UnicodeString(sc, id, NULL, status);
+ }
+ 
+-int32_t checkImpl(const SpoofImpl* This, const UnicodeString& id, CheckResult* checkResult, UErrorCode* status) {
++static int32_t checkImpl(const SpoofImpl* This, const UnicodeString& id, CheckResult* checkResult, UErrorCode* status) {
+     U_ASSERT(This != NULL);
+     U_ASSERT(checkResult != NULL);
+     checkResult->clear();