[pkgsrc/trunk]: pkgsrc/multimedia/gstreamer1 gstreamer1: don't create a setui...

[maya <maya%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/fb0f114735ee
branches:  trunk
changeset: 357829:fb0f114735ee
user:      maya <maya%pkgsrc.org@localhost>
date:      Sun Jan 29 23:24:10 2017 +0000

description:
gstreamer1: don't create a setuid binary by default, make an option for it.

gstreamer has gst-ptp-helper - helper for synchronizing time across
the network. I don't believe this option is useful enough to be a default,
but it poses a security risk.

For more information about PTP in Gstreamer, see the following post:
https://coaxion.net/blog/2015/05/ptp-network-clock-support-in-gstreamer/

bump PKGREVISION

diffstat:

 multimedia/gstreamer1/Makefile   |   3 ++-
 multimedia/gstreamer1/options.mk |  14 ++++++++++++--
 2 files changed, 14 insertions(+), 3 deletions(-)

diffs (40 lines):

diff -r 4a4d9f41022f -r fb0f114735ee multimedia/gstreamer1/Makefile
--- a/multimedia/gstreamer1/Makefile    Sun Jan 29 14:57:42 2017 +0000
+++ b/multimedia/gstreamer1/Makefile    Sun Jan 29 23:24:10 2017 +0000
@@ -1,7 +1,8 @@
-# $NetBSD: Makefile,v 1.27 2016/12/01 11:08:56 martin Exp $
+# $NetBSD: Makefile,v 1.28 2017/01/29 23:24:10 maya Exp $
 
 DISTNAME=      gstreamer-1.10.0
 PKGNAME=       ${DISTNAME:S/gstreamer/gstreamer1/}
+PKGREVISION=   1
 CATEGORIES=    multimedia
 MASTER_SITES=  http://gstreamer.freedesktop.org/src/gstreamer/
 EXTRACT_SUFX=  .tar.xz
diff -r 4a4d9f41022f -r fb0f114735ee multimedia/gstreamer1/options.mk
--- a/multimedia/gstreamer1/options.mk  Sun Jan 29 14:57:42 2017 +0000
+++ b/multimedia/gstreamer1/options.mk  Sun Jan 29 23:24:10 2017 +0000
@@ -1,7 +1,7 @@
-# $NetBSD: options.mk,v 1.5 2016/12/01 11:08:56 martin Exp $
+# $NetBSD: options.mk,v 1.6 2017/01/29 23:24:10 maya Exp $
 
 PKG_OPTIONS_VAR=       PKG_OPTIONS.gstreamer
-PKG_SUPPORTED_OPTIONS= gstreamer-gstcheck introspection
+PKG_SUPPORTED_OPTIONS= gstreamer-gstcheck introspection ptp-suid
 PKG_SUGGESTED_OPTIONS= introspection
 
 .include "../../mk/bsd.options.mk"
@@ -22,3 +22,13 @@
 .else
 CONFIGURE_ARGS+=--disable-introspection
 .endif
+
+# PTP network clock requires setuid root for gst-ptp-helper
+# It's not useful enough to be a default, but left as an option
+# for those interested in it.
+.if !empty(PKG_OPTIONS:Mptp-suid)
+SPECIAL_PERMS+=                libexec/gstreamer-1.0/gst-ptp-helper ${SETUID_ROOT_PERMS}
+CONFIGURE_ARGS+=       --with-ptp-helper-permissions=setuid-root
+.else
+CONFIGURE_ARGS+=       --with-ptp-helper-permissions=none
+.endif