[pkgsrc/trunk]: pkgsrc/www/nghttp2 nghttp2: Rototill USE_LANGUAGES and make g...

[gdt <gdt%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/58c5ef1559d4
branches:  trunk
changeset: 389968:58c5ef1559d4
user:      gdt <gdt%pkgsrc.org@localhost>
date:      Mon Jan 14 17:22:18 2019 +0000

description:
nghttp2: Rototill USE_LANGUAGES and make granular per option

Back out the previous build fix.

The base package does not even need C++, so drop from USE_LANGUAGES,
and remove GCC_REQD.  Builds on netbsd-7/amd64 with gcc 4.8.

Both options build C++ code.  Add c++14 to USE_LANGUAGES and 6 to
GCC_REQD, following upstream documentation.

diffstat:

 www/nghttp2/Makefile   |  12 ++++++++----
 www/nghttp2/options.mk |  12 +++++++-----
 2 files changed, 15 insertions(+), 9 deletions(-)

diffs (61 lines):

diff -r 2404cdfe7bf3 -r 58c5ef1559d4 www/nghttp2/Makefile
--- a/www/nghttp2/Makefile      Mon Jan 14 15:53:45 2019 +0000
+++ b/www/nghttp2/Makefile      Mon Jan 14 17:22:18 2019 +0000
@@ -1,7 +1,7 @@
-# $NetBSD: Makefile,v 1.47 2019/01/04 14:52:43 gdt Exp $
+# $NetBSD: Makefile,v 1.48 2019/01/14 17:22:18 gdt Exp $
 
 DISTNAME=      nghttp2-1.35.1
-PKGREVISION=   1
+PKGREVISION=   2
 CATEGORIES=    www
 MASTER_SITES=  ${MASTER_SITE_GITHUB:=tatsuhiro-t/}
 EXTRACT_SUFX=  .tar.xz
@@ -12,8 +12,12 @@
 COMMENT=       Implementation of HTTP/2 in C
 LICENSE=       mit
 
-USE_LANGUAGES=         c c++14
-GCC_REQD+=             6
+# Upstream documents that c++14 is required for C++ parts of the code;
+# the base package does not use C++.
+USE_LANGUAGES=         c
+# Upstream documents that gcc>=6 or clang >= 6 is required, but this
+# appears not to be true for the C parts.
+# https://github.com/nghttp2/nghttp2/issues/1293
 
 USE_LIBTOOL=           yes
 USE_TOOLS+=            gmake pkg-config
diff -r 2404cdfe7bf3 -r 58c5ef1559d4 www/nghttp2/options.mk
--- a/www/nghttp2/options.mk    Mon Jan 14 15:53:45 2019 +0000
+++ b/www/nghttp2/options.mk    Mon Jan 14 17:22:18 2019 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: options.mk,v 1.5 2017/12/21 08:18:38 adam Exp $
+# $NetBSD: options.mk,v 1.6 2019/01/14 17:22:18 gdt Exp $
 
 PKG_OPTIONS_VAR=       PKG_OPTIONS.nghttp2
 PKG_SUPPORTED_OPTIONS= nghttp2-asio nghttp2-tools
@@ -12,8 +12,9 @@
 ### Build the ASIO C++ library
 ###
 .if !empty(PKG_OPTIONS:Mnghttp2-asio)
-# Requires emplace() for associative containers, introduced in gcc 4.8.0
-GCC_REQD+=             4.8
+# Upstream documents C++14 and gcc>=6 or clang>=6
+USE_LANGUAGES+=                c++14
+GCC_REQD+=             6
 CONFIGURE_ARGS+=       --enable-asio-lib
 CONFIGURE_ARGS+=       --with-boost=${BUILDLINK_PREFIX.boost-libs}
 CONFIGURE_ARGS+=       --with-boost-asio
@@ -30,8 +31,9 @@
 ### Build apps and tools
 ###
 .if !empty(PKG_OPTIONS:Mnghttp2-tools)
-# Requires emplace() for associative containers, introduced in gcc 4.8.0
-GCC_REQD+=             4.8
+# Upstream documents C++14 and gcc>=6 or clang>=6
+USE_LANGUAGES+=                c++14
+GCC_REQD+=             6
 CONFIGURE_ARGS+=       --enable-app
 CONFIGURE_ARGS+=       --enable-hpack-tools
 PLIST.tools=           yes