[pkgsrc/trunk]: pkgsrc/games games/nethack: update to 3.6.5.

[rhialto <rhialto%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/07488706daaf
branches:  trunk
changeset: 410755:07488706daaf
user:      rhialto <rhialto%pkgsrc.org@localhost>
date:      Tue Jan 28 21:11:30 2020 +0000

description:
games/nethack: update to 3.6.5.

The NetHack DevTeam is announcing the release of NetHack 3.6.5 on January 27,
2020

NetHack 3.6.5 is the official release of NetHack that follows NetHack 3.6.4.

This release primarily corrects security issues present in NetHack versions
3.6.0, 3.6.1, 3.6.2, 3.6.3 and 3.6.4.

CVE-2020-5214   Error recovery after syntax error in configuration file is
                subject to a buffer overflow
CVE-2020-5213   SYMBOL configuration file option is subject to a buffer overflow
CVE-2020-5212   MENUCOLOR configuration file option is subject to a buffer
                overflow
CVE-2020-5211   AUTOCOMPLETE configuration file option is subject to a buffer
                overflow
CVE-2020-5210   NetHack command line -w option parsing is subject to a buffer
                overflow
CVE-2020-5209   Command line parsing of options starting with -de and -i is
                subject to a buffer overflow
CVE-2019-19905  Privilege escalation/remote code execution/crash in
                configuration parsing

You are encouraged to update to NetHack 3.6.5 as soon as possible.

Here's a brief synopsis of the handful of bug fixes included in NetHack 3.6.5:

    fix accessing mons[-1] when trying to gate in a non-valid demon
    fix accessing mons[-1] when monster figures out if a tin cures stoning
    have string_for_opt() return empty_optstr on failure
    ensure existing callers of string_for_opt() check return value
      before using it
    fix potential buffer overflow in add_menu_coloring()
    fix potential buffer overflow in sym_val()
    fix potential buffer overflow in pline(), raw_printf(), and
      config_error_add()
    fix potential buffer overflow in choose_windows()
    use vsnprintf instead of vsprintf in pline.c where possible
    Windows: includes a fix from a 3.6.4 post-release update where
      OPTIONS=map_mode:fit_to_screen could cause a game start failure
    Windows: users with C-locale unmappable names could get game start failure

All of the fixes have been incrementally published on the public Git
repository for the game. A more complete list can be found in the game's
sources in doc/fixes36.5. As usual, a warning that some entries in that
file may also be "spoilers".

Existing saved games and bones files from 3.6.0 through to 3.6.4 should
work with 3.6.5, assuming that the same build configuration options were
used.

diffstat:

 games/nethack-lib/Makefile        |   3 +--
 games/nethack-lib/Makefile.common |   4 ++--
 games/nethack-lib/distinfo        |  10 +++++-----
 games/nethack-x11/Makefile        |   3 +--
 4 files changed, 9 insertions(+), 11 deletions(-)

diffs (65 lines):

diff -r 73ef08e6995c -r 07488706daaf games/nethack-lib/Makefile
--- a/games/nethack-lib/Makefile        Tue Jan 28 19:20:29 2020 +0000
+++ b/games/nethack-lib/Makefile        Tue Jan 28 21:11:30 2020 +0000
@@ -1,10 +1,9 @@
-# $NetBSD: Makefile,v 1.33 2020/01/08 16:55:13 pho Exp $
+# $NetBSD: Makefile,v 1.34 2020/01/28 21:11:30 rhialto Exp $
 #
 
 .include               "../../games/nethack-lib/Makefile.common"
 
 PKGNAME=               nethack-lib-${NETHACK_VERSION}
-PKGREVISION=           1
 
 COMMENT=               Data files for Nethack
 
diff -r 73ef08e6995c -r 07488706daaf games/nethack-lib/Makefile.common
--- a/games/nethack-lib/Makefile.common Tue Jan 28 19:20:29 2020 +0000
+++ b/games/nethack-lib/Makefile.common Tue Jan 28 21:11:30 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.common,v 1.41 2020/01/26 17:31:16 rillig Exp $
+# $NetBSD: Makefile.common,v 1.42 2020/01/28 21:11:30 rhialto Exp $
 #
 # used by games/nethack/Makefile
 # used by games/nethack-lib/Makefile
@@ -11,7 +11,7 @@
 #      The desired owner and the file mode of game executables.
 #
 
-NETHACK_BASEVER=       3.6.4
+NETHACK_BASEVER=       3.6.5
 NETHACK_VERSION=       ${NETHACK_BASEVER}
 NETHACK_DISTVER=       ${NETHACK_BASEVER:S/.//g}
 NETHACK_DIR=           nethackdir${NETHACK_SAVEVER:S/.//g}
diff -r 73ef08e6995c -r 07488706daaf games/nethack-lib/distinfo
--- a/games/nethack-lib/distinfo        Tue Jan 28 19:20:29 2020 +0000
+++ b/games/nethack-lib/distinfo        Tue Jan 28 21:11:30 2020 +0000
@@ -1,9 +1,9 @@
-$NetBSD: distinfo,v 1.25 2020/01/08 16:55:13 pho Exp $
+$NetBSD: distinfo,v 1.26 2020/01/28 21:11:30 rhialto Exp $
 
-SHA1 (nethack-364-src.tgz) = e8166806a65893d7b843718c37b8aa9e87cfcef1
-RMD160 (nethack-364-src.tgz) = 0af138fd481e6359f265d85423a36a160692dc92
-SHA512 (nethack-364-src.tgz) = c951f939d50027b4468ebd2e32f79771e696035df0918b814bf02899f5c1e89d462ebc3f63155c23f5c627e66ca74244512d666b102c380242df1500a2c0afa9
-Size (nethack-364-src.tgz) = 5573777 bytes
+SHA1 (nethack-365-src.tgz) = fdf458c94b82876734e3b55fb93af14c3bb4d36d
+RMD160 (nethack-365-src.tgz) = 3c340be88f707ac0ab3c7f12e0758fa8fdcccb9d
+SHA512 (nethack-365-src.tgz) = 3ac1aeaa4a5e283bc3ee9520d0f37ccd8a0f973840d2116edd50f52a2f53088370203023579519eae98e56e0f90c9d0f87b38cf1ffa73aba5ee69ef32d1aa617
+Size (nethack-365-src.tgz) = 5576401 bytes
 SHA1 (patch-ai) = 73c5b2ea1227531089474705f2f18bc411366365
 SHA1 (patch-include_config.h) = d3e054a8b30d628513dcb445b10ce586685c7ea6
 SHA1 (patch-include_system.h) = b1b53f513c3f6983e0e56eace74c71875b5df3f2
diff -r 73ef08e6995c -r 07488706daaf games/nethack-x11/Makefile
--- a/games/nethack-x11/Makefile        Tue Jan 28 19:20:29 2020 +0000
+++ b/games/nethack-x11/Makefile        Tue Jan 28 21:11:30 2020 +0000
@@ -1,9 +1,8 @@
-# $NetBSD: Makefile,v 1.40 2019/10/24 11:52:08 pho Exp $
+# $NetBSD: Makefile,v 1.41 2020/01/28 21:11:30 rhialto Exp $
 
 .include "../../games/nethack-lib/Makefile.common"
 
 PKGNAME=               nethack-x11-${NETHACK_VERSION}
-PKGREVISION=           5
 COMMENT=               The X11+tty version of NetHack
 
 CATEGORIES+=           x11